public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ANNIE LI <annie.li@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Paul Durrant <Paul.Durrant@citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"jeremy@goop.org" <jeremy@goop.org>,
	"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>
Subject: Re: [PATCH 1/2] xen/granttable: Support sub-page grants
Date: Wed, 07 Dec 2011 18:50:32 +0800	[thread overview]
Message-ID: <4EDF44F8.8060206@oracle.com> (raw)
In-Reply-To: <1323254036.23681.142.camel@zakaz.uk.xensource.com>


> The existing convention seems to be for _ref to be a suffix, although
> it's only actually used on the end_*_ref ones.
> +       int (*end_foreign_access_ref)(grant_ref_t, int);
> +       unsigned long (*end_foreign_transfer_ref)(grant_ref_t);
>
> Also it occurs to me that access_* sounds like something which uses a
> ref rather than something which sets one up. The existing hook to setup
> a normal grant is called "update_entry". Perhaps
> update_{subpage,transitive}_entry?
Yes, you are right.
Just like the existing code:
gnttab_grant_foreign_access   VS   gnttab_grant_foreign_access_subpage
update_entry in gnttab_grant_foreign_access_ref  VS  
update_{subpage,transitive}_entry in 
gnttab_grant_foreign_access_{subpage,trans}_ref

Thanks
Annie

  reply	other threads:[~2011-12-07 10:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06 10:53 xen: patches for supporting sub-page and transitive grants ANNIE LI
2011-12-06 10:56 ` [PATCH 1/2] xen/granttable: Support sub-page grants annie.li
2011-12-06 11:42   ` Ian Campbell
2011-12-06 17:20     ` Jeremy Fitzhardinge
2011-12-07  3:36       ` ANNIE LI
2011-12-07  3:36     ` ANNIE LI
2011-12-07  8:59       ` Paul Durrant
2011-12-07  9:57         ` Ian Campbell
2011-12-07 10:27           ` ANNIE LI
2011-12-07 10:33             ` Ian Campbell
2011-12-07 10:50               ` ANNIE LI [this message]
2011-12-07 19:41         ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-12-07  9:56       ` Ian Campbell
2011-12-07 10:27         ` ANNIE LI
2011-12-07 10:36   ` ANNIE LI
2011-12-06 10:57 ` [PATCH 2/2] xen/granttable: Support transitive grants annie.li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDF44F8.8060206@oracle.com \
    --to=annie.li@oracle.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kurt.hackel@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox