From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756622Ab1LGPbz (ORCPT ); Wed, 7 Dec 2011 10:31:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8418 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756502Ab1LGPbx (ORCPT ); Wed, 7 Dec 2011 10:31:53 -0500 Message-ID: <4EDF86E4.3050701@redhat.com> Date: Wed, 07 Dec 2011 17:31:48 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: Sasha Levin CC: linux-kernel@vger.kernel.org, Joerg Roedel , Marcelo Tosatti , kvm@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: VMX: Notify if VMX is already in use References: <1322764218-4698-1-git-send-email-levinsasha928@gmail.com> <4EDF7590.5060701@redhat.com> <1323267521.4009.11.camel@lappy> <4EDF76D6.7020800@redhat.com> <1323267891.4009.16.camel@lappy> <4EDF7797.9080103@redhat.com> <1323270953.4009.21.camel@lappy> In-Reply-To: <1323270953.4009.21.camel@lappy> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/2011 05:15 PM, Sasha Levin wrote: > > Ah, maybe they do it differently on AMD. Or they changed things. > > I've grabbed their code just to see whats going on there and traced the > vmxon calls back to module init. > > Are you sure it ever happened on-demand and not on init? If you are, > I'll actually build that module and give it a go :) I'm pretty sure, but they likely changed things. vmxon/off all the time is not very performant. -- error compiling committee.c: too many arguments to function