linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
	patches@linaro.org, eric.miao@linaro.org,
	Nancy Chen <Nancy.Chen@freescale.com>, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] Regulator: Add Anatop regulator driver
Date: Thu, 08 Dec 2011 00:30:40 +0800	[thread overview]
Message-ID: <4EDF94B0.1050108@linaro.org> (raw)
In-Reply-To: <20111207155457.GB22355@opensource.wolfsonmicro.com>

(2011年12月07日 23:54), Mark Brown wrote:
> On Wed, Dec 07, 2011 at 09:53:18PM +0800, Ying-Chun Liu (PaulLiu) wrote:
>> From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
>>
>> Anatop regulator driver is used by i.MX6 SoC. This patch adds the
>> Anatop regulator driver.
> 
> This changelog isn't terribly verbose but looking at the code what
> you've actually got here is a driver that is simply an indirection
> layer for the regulator API and no explanation as to why you're doing
> this.  My first thought is that anything using this driver should just
> be a regulator driver directly.

Hi Mark,

Thanks. I think you are correct. I just search the LKML and found that
this has been discussed already.
https://lkml.org/lkml/2011/10/28/325

So what we should do is forget this patch and use fixed regulators
rather than create an indirection layer.

Many Thanks,
Paul


  reply	other threads:[~2011-12-07 16:30 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-07 13:53 [PATCH] Regulator: Add Anatop regulator driver Ying-Chun Liu (PaulLiu)
2011-12-07 13:53 ` Ying-Chun Liu (PaulLiu)
2011-12-07 15:54   ` Mark Brown
2011-12-07 16:30     ` Ying-Chun Liu (PaulLiu) [this message]
2011-12-21  9:03   ` [PATCHv2] " Ying-Chun Liu (PaulLiu)
2011-12-22 11:33     ` Mark Brown
2011-12-24 12:37       ` Mark Brown
2011-12-27 10:06       ` Ying-Chun Liu (PaulLiu)
2011-12-27 10:40         ` Mark Brown
2011-12-27 10:16     ` [PATCH v3] " Ying-Chun Liu (PaulLiu)
2011-12-27 10:52       ` Mark Brown
2011-12-27 11:38       ` Shawn Guo
2012-02-08 20:51       ` [PATCH v4 1/2] mfd: Add anatop mfd driver Ying-Chun Liu (PaulLiu)
2012-02-08 20:51         ` [PATCH v4 2/2] Regulator: Add Anatop regulator driver Ying-Chun Liu (PaulLiu)
2012-02-09 11:24           ` Mark Brown
2012-02-11  6:36           ` Shawn Guo
2012-02-11 13:17             ` Mark Brown
2012-02-11  6:05         ` [PATCH v4 1/2] mfd: Add anatop mfd driver Shawn Guo
2012-02-21 11:17         ` Samuel Ortiz
2012-03-01  9:19           ` Ying-Chun Liu (PaulLiu)
2012-03-01  9:10         ` [PATCH v5 " Ying-Chun Liu (PaulLiu)
2012-03-01  9:10           ` [PATCH v5 2/2] Regulator: Add Anatop regulator driver Ying-Chun Liu (PaulLiu)
2012-03-01 11:17             ` Mark Brown
2012-03-01 11:30           ` [PATCH v5 1/2] mfd: Add anatop mfd driver Mark Brown
2012-03-02  7:00           ` [PATCH v6 " Ying-Chun Liu (PaulLiu)
2012-03-02  7:00             ` [PATCH v6 2/2] Regulator: Add Anatop regulator driver Ying-Chun Liu (PaulLiu)
2012-03-04  6:51               ` Shawn Guo
2012-03-04 13:29                 ` Mark Brown
2012-03-02  7:07             ` [PATCH v6 1/2] mfd: Add anatop mfd driver Venu Byravarasu
2012-03-02  7:51               ` Ying-Chun Liu (PaulLiu)
2012-03-02  8:02                 ` Venu Byravarasu
2012-03-02 14:00             ` Peter Korsgaard
2012-03-03 17:39             ` [PATCH v7 " Ying-Chun Liu (PaulLiu)
2012-03-03 17:58               ` Mark Brown
2012-03-04  5:25               ` Shawn Guo
2012-03-04  5:42               ` Shawn Guo
2012-03-04  5:55               ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDF94B0.1050108@linaro.org \
    --to=paul.liu@linaro.org \
    --cc=Nancy.Chen@freescale.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=eric.miao@linaro.org \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).