From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752859Ab1LHJlW (ORCPT ); Thu, 8 Dec 2011 04:41:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19355 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713Ab1LHJlT (ORCPT ); Thu, 8 Dec 2011 04:41:19 -0500 Message-ID: <4EE08606.2060508@redhat.com> Date: Thu, 08 Dec 2011 11:40:22 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: Raghavendra K T CC: Marcelo Tosatti , Raghavendra K T , Greg Kroah-Hartman , KVM , Konrad Rzeszutek Wilk , Sedat Dilek , Virtualization , Jeremy Fitzhardinge , x86@kernel.org, "H. Peter Anvin" , Dave Jiang , Thomas Gleixner , Stefano Stabellini , Gleb Natapov , Yinghai Lu , Ingo Molnar , Rik van Riel , Xen , LKML , Srivatsa Vaddagiri , Peter Zijlstra , Sasha Levin , Suzuki Poulose , Dave Hansen , Jeremy Fitzhardinge Subject: Re: [PATCH RFC V3 2/4] kvm hypervisor : Add a hypercall to KVM hypervisor to support pv-ticketlocks References: <20111130085921.23386.89708.sendpatchset@oc5400248562.ibm.com> <20111130085959.23386.69166.sendpatchset@oc5400248562.ibm.com> <20111207104849.GA24849@amt.cnet> <4EDF5413.1030107@linux.vnet.ibm.com> <20111207123330.GA32212@amt.cnet> <4EDF6049.2030204@redhat.com> <20111207133947.GA1708@amt.cnet> <4EDF7DC5.5010504@redhat.com> <4EDF987B.8040900@linux.vnet.ibm.com> In-Reply-To: <4EDF987B.8040900@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/2011 06:46 PM, Raghavendra K T wrote: > On 12/07/2011 08:22 PM, Avi Kivity wrote: >> On 12/07/2011 03:39 PM, Marcelo Tosatti wrote: >>>> Also I think we can keep the kicked flag in vcpu->requests, no need >>>> for >>>> new storage. >>> >>> Was going to suggest it but it violates the currently organized >>> processing of entries at the beginning of vcpu_enter_guest. >>> >>> That is, this "kicked" flag is different enough from vcpu->requests >>> processing that a separate variable seems worthwhile (even more >>> different with convertion to MP_STATE at KVM_GET_MP_STATE). >> >> IMO, it's similar to KVM_REQ_EVENT (which can also cause mpstate to >> change due to apic re-evaluation). >> > > Ok, So what I understand is we have to either : > 1. retain current kick flag AS-IS but would have to make it migration > friendly. [I still have to get more familiar with migration side] > or > 2. introduce notion similar to KVM_REQ_PVLOCK_KICK(??) to be part of > vcpu->requests. > > So what would be better? Please let me know. > IMO, KVM_REQ. -- error compiling committee.c: too many arguments to function