Re: [PATCH -v2] ibft: Fix finding IBFT ACPI table on UEFI

[Yinghai Lu <yinghai.lu@oracle.com>]

On 12/08/2011 11:08 AM, Konrad Rzeszutek Wilk wrote:

> On Thu, Dec 08, 2011 at 08:52:33AM -0800, Yinghai Lu wrote:
>>
>> Found one system with UEFI/iBFT, Kernel does not detect the iBFT during
>                                    ^^^^^ - lowercase 'kernel' please.
>> iscsi_ibft module loading.
> 
> I get this when compiling it:
> 
> Setup is 16588 bytes (padded to 16896 bytes).
> System is 6277 kB
> CRC 7fe65506
> Kernel: arch/x86/boot/bzImage is ready  (#2)
> ERROR: "find_ibft_region" [drivers/firmware/iscsi_ibft.ko] undefined!
> 
> This is on i386 x86 build when doing 'make allmodconfig'.


then will need more cleaner change.

> 
>>
>> the root cause: for x86, We have calling of find_ibft_region() much early.
>                           ^^ - You only need to uppercase it if you
> start a sentence - which is not what you are doing. So please make it
> lowercase.
>> in setup_arch() before ACPI is enabled.
> 
> This is what I changed the git description to:
> 
>  Root cause: on x86 (UEFI), we are calling find_ibft_region() much
>  earlier - specifically in setup_arch() before ACPI is enabled.
> 


will use that...

Thanks

Yinghai