Re: [PATCH V2 1/2] xen/granttable: Support sub-page grants

[annie li <annie.li@oracle.com>]

On 2011-12-9 16:48, Paul Durrant wrote:
>> -----Original Message-----
>> From: Ian Campbell
>> Sent: 09 December 2011 08:37
>> To: annie li
>> Cc: Paul Durrant; xen-devel@lists.xensource.com; linux-
>> kernel@vger.kernel.org; konrad.wilk@oracle.com; jeremy@goop.org;
>> kurt.hackel@oracle.com
>> Subject: Re: [PATCH V2 1/2] xen/granttable: Support sub-page grants
>>
>> On Fri, 2011-12-09 at 07:45 +0000, annie li wrote:
>>     
>>> On 2011-12-9 13:19, annie li wrote:
>>>       
>>>> Hi Paul,
>>>>
>>>>         
>>>>>>> #define get_free_entry()    get_free_entries(1)
>>>>>>>               
>>>> Is this necessary? Maybe you defined this to keep consistence
>>>>         
>> with
>>     
>>>> put_free_entry(ref)?
>>>> But other functions such as gnttab_grant_foreign_transfer and
>>>> gnttab_grant_foreign_access all call get_free_entries(1). Maybe
>>>>         
>> it
>>     
>>>> is better to keep initial get_free_entries(1) code?
>>>>         
>>> Another approach is doing those work in a separate patch --
>>>       
>> changing
>>     
>>> get_free_entries to get_free_entry in following 4 functions:
>>>       
>> I think you shouldn't get too bogged down in get_free_entry() vs
>> get_free_entries(1) for the purposes of this patch series.
>>
>>     
>
> Annie,
>
>   Yes, don't worry about get_free_entry(). I only defined it for the sake of symmetry in the code I posted.
>   
OK, will keep get_free_entries(1) unchanged.

Thanks
Annie
>   Paul
>