From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753541Ab1LIMlk (ORCPT ); Fri, 9 Dec 2011 07:41:40 -0500 Received: from mx2.parallels.com ([64.131.90.16]:50833 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570Ab1LIMlj (ORCPT ); Fri, 9 Dec 2011 07:41:39 -0500 Message-ID: <4EE201DE.9040102@parallels.com> Date: Fri, 9 Dec 2011 10:41:02 -0200 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: KAMEZAWA Hiroyuki CC: , , , , , , , , , , , , , Subject: Re: [PATCH v8 2/9] foundations of per-cgroup memory pressure controlling. References: <1323120903-2831-1-git-send-email-glommer@parallels.com> <1323120903-2831-3-git-send-email-glommer@parallels.com> <20111209102438.2db705d0.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20111209102438.2db705d0.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [201.82.130.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08/2011 11:24 PM, KAMEZAWA Hiroyuki wrote: > On Mon, 5 Dec 2011 19:34:56 -0200 > Glauber Costa wrote: > >> This patch replaces all uses of struct sock fields' memory_pressure, >> memory_allocated, sockets_allocated, and sysctl_mem to acessor >> macros. Those macros can either receive a socket argument, or a mem_cgroup >> argument, depending on the context they live in. >> >> Since we're only doing a macro wrapping here, no performance impact at all is >> expected in the case where we don't have cgroups disabled. >> >> Signed-off-by: Glauber Costa >> CC: David S. Miller >> CC: Hiroyouki Kamezawa >> CC: Eric W. Biederman >> CC: Eric Dumazet > > please get ack from network guys. > from me. > Reviewed-by: KAMEZAWA Hiroyuki > Ok. I think that now with all the Reviewed-by:'s I will resend it as a Request for Inclusion for Dave (plus fixing the problem you noted in patch 1)