Re: [PATCH] mfd: tps65910: Handle clear-mask correctly

[Graeme Gregory <gg@slimlogic.co.uk>]

I missed the original mail, but yes it looks good to me please push.

Graeme

On 12/12/11 08:30, Samuel Ortiz wrote:
> Hi Marcus,
>
> On Tue, Nov 22, 2011 at 02:39:51PM +0100, Marcus Folkesson wrote:
>> The function is not actually cleaing the bitmask.
> This looks like a valid fix, and all the tps65910_clear_bits() callers seem to
> expect that behaviour. Graeme, I'm going to try to push this one for 3.2,
> unless you object to it.
>
> Cheers,
> Samuel.
>
>> Signed-off-by: Marcus Folkesson<marcus.folkesson@gmail.com>
>> ---
>>   drivers/mfd/tps65910.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
>> index 6f5b8cf..c1da84b 100644
>> --- a/drivers/mfd/tps65910.c
>> +++ b/drivers/mfd/tps65910.c
>> @@ -120,7 +120,7 @@ int tps65910_clear_bits(struct tps65910 *tps65910, u8 reg, u8 mask)
>>   		goto out;
>>   	}
>>
>> -	data&= mask;
>> +	data&= ~mask;
>>   	err = tps65910_i2c_write(tps65910, reg, 1,&data);
>>   	if (err)
>>   		dev_err(tps65910->dev, "write to reg %x failed\n", reg);
>> -- 
>> 1.7.5.4
>>