From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753464Ab1LLRKO (ORCPT ); Mon, 12 Dec 2011 12:10:14 -0500 Received: from terminus.zytor.com ([198.137.202.10]:40263 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952Ab1LLRKK (ORCPT ); Mon, 12 Dec 2011 12:10:10 -0500 Message-ID: <4EE63552.5000704@zytor.com> Date: Mon, 12 Dec 2011 09:09:38 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: Matt Fleming CC: Linus Torvalds , Keith Packard , linux-kernel@vger.kernel.org, Matthew Garrett , Zhang Rui , Huang Ying , Andrew Morton , Ingo Molnar Subject: Re: [PATCH] Revert "x86, efi: Calling __pa() with an ioremap()ed address is invalid" References: <1323648762-2148-1-git-send-email-keithp@keithp.com> <1323684086.3669.16.camel@mfleming-mobl1.ger.corp.intel.com> In-Reply-To: <1323684086.3669.16.camel@mfleming-mobl1.ger.corp.intel.com> X-Enigmail-Version: 1.3.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2011 02:01 AM, Matt Fleming wrote: > > At this late -rc stage I agree it makes sense to revert this. The > CONFIG_X86_32 oops that the patch fixes has been around for years and no > one seems to have encountered it (until now), whereas this new > regression is likely to affect many more users. > Agreed on both accounts. For the revert: Acked-by: H. Peter Anvin ... or we can push it in the next x86/urgent batch. However, still want to chase the root cause down. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.