[PATCH] backlight: ep93xx_bl: remove duplicated header include

[PATCH] backlight: ep93xx_bl: remove duplicated header include

[Jingoo Han]

This patch removes duplicated module header for EP93xx backlight
driver.
drivers/video/backlight/ep93xx_bl.c: module.h is included more
than once.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/video/backlight/ep93xx_bl.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
index c74a6f4..4893dff 100644
--- a/drivers/video/backlight/ep93xx_bl.c
+++ b/drivers/video/backlight/ep93xx_bl.c
@@ -10,10 +10,8 @@
  * This driver controls the pulse width modulated brightness control output,
  * BRIGHT, on the Cirrus EP9307, EP9312, and EP9315 processors.
  */
-
 #include <linux/module.h>
 #include <linux/platform_device.h>
-#include <linux/module.h>
 #include <linux/io.h>
 #include <linux/fb.h>
 #include <linux/backlight.h>
-- 
1.7.1

RE: [PATCH] backlight: ep93xx_bl: remove duplicated header include

[H Hartley Sweeten]

On Monday, December 12, 2011 12:51 AM, Jingoo Han wrote:
>
> This patch removes duplicated module header for EP93xx backlight
> driver.
> drivers/video/backlight/ep93xx_bl.c: module.h is included more
> than once.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Hmm.. Looks like there were two commits that add it...

commit 15b1a8f2b990c0c1dacfad0e5ccaf05c32c52147
Author: Axel Lin <axel.lin@gmail.com>
Date:   Thu Aug 25 15:59:14 2011 -0700

	drivers/video/backlight/ep93xx_bl.c: add missing include of linux/module.h

commit 355b200bacdb6017669cdc5bc9e7b1037aac42a2
Author: Paul Gortmaker <paul.gortmaker@windriver.com>
Date:   Sun Jul 3 16:17:28 2011 -0400

	video: Add module.h to drivers/video files who really use it.

It is needed, but there should only be one so...

Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>

Re: [PATCH] backlight: ep93xx_bl: remove duplicated header include

[Ryan Mallon]

On 12/12/11 18:51, Jingoo Han wrote:

> This patch removes duplicated module header for EP93xx backlight
> driver.
> drivers/video/backlight/ep93xx_bl.c: module.h is included more
> than once.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/video/backlight/ep93xx_bl.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
> index c74a6f4..4893dff 100644
> --- a/drivers/video/backlight/ep93xx_bl.c
> +++ b/drivers/video/backlight/ep93xx_bl.c
> @@ -10,10 +10,8 @@
>   * This driver controls the pulse width modulated brightness control output,
>   * BRIGHT, on the Cirrus EP9307, EP9312, and EP9315 processors.
>   */
> -


Please don't remove the blank line between the header comment and the
first include.

~Ryan

>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> -#include <linux/module.h>
>  #include <linux/io.h>
>  #include <linux/fb.h>
>  #include <linux/backlight.h>