* [PATCH] arch/tile: misplaced parens near likely
@ 2011-12-12 22:34 roel
2011-12-14 16:36 ` Chris Metcalf
0 siblings, 1 reply; 2+ messages in thread
From: roel @ 2011-12-12 22:34 UTC (permalink / raw)
To: Chris Metcalf, Andrew Morton, LKML
Parentheses were missing.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
arch/tile/lib/spinlock_32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
This is what it should be, right?
diff --git a/arch/tile/lib/spinlock_32.c b/arch/tile/lib/spinlock_32.c
index cb0999f..b16ac49 100644
--- a/arch/tile/lib/spinlock_32.c
+++ b/arch/tile/lib/spinlock_32.c
@@ -144,7 +144,7 @@ void arch_read_unlock(arch_rwlock_t *rwlock)
for (;;) {
__insn_mtspr(SPR_INTERRUPT_CRITICAL_SECTION, 1);
val = __insn_tns((int *)&rwlock->lock);
- if (likely(val & 1) == 0) {
+ if (likely((val & 1) == 0)) {
rwlock->lock = val - (1 << _RD_COUNT_SHIFT);
__insn_mtspr(SPR_INTERRUPT_CRITICAL_SECTION, 0);
break;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arch/tile: misplaced parens near likely
2011-12-12 22:34 [PATCH] arch/tile: misplaced parens near likely roel
@ 2011-12-14 16:36 ` Chris Metcalf
0 siblings, 0 replies; 2+ messages in thread
From: Chris Metcalf @ 2011-12-14 16:36 UTC (permalink / raw)
To: roel; +Cc: Andrew Morton, LKML
On 12/12/2011 5:34 PM, roel wrote:
> Parentheses were missing.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Thanks, I'll take this into the tile tree.
> ---
> arch/tile/lib/spinlock_32.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> This is what it should be, right?
>
> diff --git a/arch/tile/lib/spinlock_32.c b/arch/tile/lib/spinlock_32.c
> index cb0999f..b16ac49 100644
> --- a/arch/tile/lib/spinlock_32.c
> +++ b/arch/tile/lib/spinlock_32.c
> @@ -144,7 +144,7 @@ void arch_read_unlock(arch_rwlock_t *rwlock)
> for (;;) {
> __insn_mtspr(SPR_INTERRUPT_CRITICAL_SECTION, 1);
> val = __insn_tns((int *)&rwlock->lock);
> - if (likely(val & 1) == 0) {
> + if (likely((val & 1) == 0)) {
> rwlock->lock = val - (1 << _RD_COUNT_SHIFT);
> __insn_mtspr(SPR_INTERRUPT_CRITICAL_SECTION, 0);
> break;
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-14 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-12 22:34 [PATCH] arch/tile: misplaced parens near likely roel
2011-12-14 16:36 ` Chris Metcalf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox