* [PATCH] Add PCI IDs for Motorola H24 HSPA USB module.
@ 2011-12-12 13:10 Krzysztof Hałasa
2011-12-12 13:24 ` Oliver Neukum
2011-12-13 20:32 ` Denis Kuzmenko
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Hałasa @ 2011-12-12 13:10 UTC (permalink / raw)
To: Oliver Neukum; +Cc: lkml
Add PCI IDs for Motorola H24 HSPA USB module.
Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1458,6 +1458,16 @@ static const struct usb_device_id acm_ids[] = {
},
{ USB_DEVICE(0x22b8, 0x6425), /* Motorola MOTOMAGX phones */
},
+ /* Motorola H24 HSPA module: */
+ { USB_DEVICE(0x22b8, 0x2d91) }, /* modem */
+ { USB_DEVICE(0x22b8, 0x2d92) }, /* modem + diagnostics */
+ { USB_DEVICE(0x22b8, 0x2d93) }, /* modem + AT port */
+ { USB_DEVICE(0x22b8, 0x2d95) }, /* modem + AT port + diagnostics */
+ { USB_DEVICE(0x22b8, 0x2d96) }, /* modem + NMEA */
+ { USB_DEVICE(0x22b8, 0x2d97) }, /* modem + diagnostics + NMEA */
+ { USB_DEVICE(0x22b8, 0x2d99) }, /* modem + AT port + NMEA */
+ { USB_DEVICE(0x22b8, 0x2d9a) }, /* modem + AT port + diagnostics + NMEA */
+
{ USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */
.driver_info = NO_UNION_NORMAL, /* union descriptor misplaced on
data interface instead of
--
Krzysztof Halasa
Research Institute for Automation and Measurements
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Add PCI IDs for Motorola H24 HSPA USB module.
2011-12-12 13:10 [PATCH] Add PCI IDs for Motorola H24 HSPA USB module Krzysztof Hałasa
@ 2011-12-12 13:24 ` Oliver Neukum
2011-12-12 13:48 ` Krzysztof Hałasa
2011-12-13 20:32 ` Denis Kuzmenko
1 sibling, 1 reply; 4+ messages in thread
From: Oliver Neukum @ 2011-12-12 13:24 UTC (permalink / raw)
To: Krzysztof Hałasa; +Cc: Oliver Neukum, lkml
Am Montag, 12. Dezember 2011, 14:10:23 schrieb Krzysztof Hałasa:
> Add PCI IDs for Motorola H24 HSPA USB module.
>
> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
Why does it need so many IDs?
Also please send to linux-usb, not lkml.
Regards
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add PCI IDs for Motorola H24 HSPA USB module.
2011-12-12 13:24 ` Oliver Neukum
@ 2011-12-12 13:48 ` Krzysztof Hałasa
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Hałasa @ 2011-12-12 13:48 UTC (permalink / raw)
To: Oliver Neukum; +Cc: Oliver Neukum, lkml
Oliver Neukum <oneukum@suse.de> writes:
>> Add PCI IDs for Motorola H24 HSPA USB module.
> Why does it need so many IDs?
It has several configurations, each with a different ID.
> Also please send to linux-usb, not lkml.
Will send a copy.
--
Krzysztof Halasa
Research Institute for Automation and Measurements
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add PCI IDs for Motorola H24 HSPA USB module.
2011-12-12 13:10 [PATCH] Add PCI IDs for Motorola H24 HSPA USB module Krzysztof Hałasa
2011-12-12 13:24 ` Oliver Neukum
@ 2011-12-13 20:32 ` Denis Kuzmenko
1 sibling, 0 replies; 4+ messages in thread
From: Denis Kuzmenko @ 2011-12-13 20:32 UTC (permalink / raw)
To: Krzysztof Hałasa; +Cc: Oliver Neukum, lkml
On 12/12/2011 03:10 PM, Krzysztof Hałasa wrote:
> Add PCI IDs for Motorola H24 HSPA USB module.
>
> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
>
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1458,6 +1458,16 @@ static const struct usb_device_id acm_ids[] = {
> },
> { USB_DEVICE(0x22b8, 0x6425), /* Motorola MOTOMAGX phones */
> },
> + /* Motorola H24 HSPA module: */
AFAIK, Motorola's M2M division was acquired by Telit in March 2011, so
now those devices are called Telit H24. Can you please add note about
that so readers can understand that this code applies or Telit H24 too?
--
Best regards, Denis Kuzmenko.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-13 20:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-12 13:10 [PATCH] Add PCI IDs for Motorola H24 HSPA USB module Krzysztof Hałasa
2011-12-12 13:24 ` Oliver Neukum
2011-12-12 13:48 ` Krzysztof Hałasa
2011-12-13 20:32 ` Denis Kuzmenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox