From: Jeff Garzik <jeff@garzik.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Namjae Jeon <linkinjeon@gmail.com>,
Amit Sahrawat <amit.sahrawat83@gmail.com>,
Nam-Jae Jeon <namjae.jeon@samsung.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] scsi: retrieve cache mode using ATA_16 if normal routine fails
Date: Tue, 13 Dec 2011 15:38:17 -0500 [thread overview]
Message-ID: <4EE7B7B9.7060700@garzik.org> (raw)
In-Reply-To: <1323766382.8163.12.camel@dabdike>
On 12/13/2011 03:53 AM, James Bottomley wrote:
> On Tue, 2011-12-13 at 09:20 +0900, Namjae Jeon wrote:
>>> This whole patch looks like a layering violation. Why not just update
>>> the SAT layer to translate the MODE SENSE correctly?
>> Would plz you explain more ? I didn't clearly understand your point yet.
>
> The ATA layer does translation for SCSI commands. Just translate the
> mode sense correctly to use IDENTIFY word 85. It's a smaller patch and
> no need for any changes in SCSI.
Correct.
> Actually, looking at it, it seems to be correct ... why is it not
> working for you?
Indeed -- the patch attempts to address a problem that the libata-scsi
translation module already handles.
I would look at why the device is not properly reporting that already.
If necessary, we would update libata not SCSI.
Jeff
next prev parent reply other threads:[~2011-12-13 20:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 11:18 [PATCH 1/1] scsi: retrieve cache mode using ATA_16 if normal routine fails Amit Sahrawat
2011-12-12 12:51 ` James Bottomley
2011-12-13 0:20 ` Namjae Jeon
[not found] ` <CADDb1s2SOK5sC3N0OOdkBrPuDKc2d2A4z4yso4jYs=1rbxNmkA@mail.gmail.com>
2011-12-13 4:56 ` Amit Sahrawat
2011-12-13 8:53 ` James Bottomley
2011-12-13 12:15 ` Amit Sahrawat
2011-12-13 20:38 ` Jeff Garzik [this message]
2011-12-14 3:44 ` Amit Sahrawat
2011-12-14 7:39 ` James Bottomley
2011-12-15 0:25 ` Namjae Jeon
2012-01-27 5:20 ` Amit Sahrawat
-- strict thread matches above, loose matches on Subject: below --
2012-02-03 12:59 Amit Sahrawat
2012-02-05 12:05 ` Sergei Shtylyov
2012-02-06 5:40 ` Amit Sahrawat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE7B7B9.7060700@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=amit.sahrawat83@gmail.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox