From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755879Ab1LMVfP (ORCPT ); Tue, 13 Dec 2011 16:35:15 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:53646 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753692Ab1LMVfL (ORCPT ); Tue, 13 Dec 2011 16:35:11 -0500 Message-ID: <4EE7C4AD.8090805@solonet.org.ua> Date: Tue, 13 Dec 2011 23:33:33 +0200 From: Denis Kuzmenko User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20111110 Icedove/3.0.11 MIME-Version: 1.0 To: Joe Perches CC: "linux-kernel@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Grant Likely , Linus Walleij , Kukjin Kim , Richard Purdie Subject: Re: [PATCH v3 resend2] s3c/s3c24xx: arm: leds: Make s3c24xx LEDS driver use gpiolib References: <4EE7B41C.5080006@solonet.org.ua> <1323810417.3837.25.camel@joe2Laptop> <4EE7C1C9.8080000@solonet.org.ua> <1323811732.3837.27.camel@joe2Laptop> In-Reply-To: <1323811732.3837.27.camel@joe2Laptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/13/2011 11:28 PM, Joe Perches wrote: > On Tue, 2011-12-13 at 23:21 +0200, Denis Kuzmenko wrote: >> Hi Joe, >> Thank you for review. >> >> On 12/13/2011 11:06 PM, Joe Perches wrote: >>> On Tue, 2011-12-13 at 22:22 +0200, Denis Kuzmenko wrote: >>>> Make s3c24xx LEDS driver use gpiolib. Fix error disabling pull during probe. > Your choice, but I think consistency is better. > > The LEDF_ACTLOW use is dependent on it being #defined > to 1 when using ^. I think that's unintelligible. Sorry, can't understand. Can you please clarify last two sentences? -- Best regards, Denis Kuzmenko.