From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: linux-aio@kvack.org
Cc: linux-kernel@vger.kernel.org,
Chris Mason <chris.mason@oracle.com>,
Jens Axboe <axboe@kernel.dk>, Andi Kleen <ak@linux.intel.com>,
Jeff Moyer <jmoyer@redhat.com>
Subject: [PATCH] AIO: Don't plug the I/O queue in do_io_submit()
Date: Tue, 13 Dec 2011 15:44:45 -0600 [thread overview]
Message-ID: <4EE7C74D.1020306@oracle.com> (raw)
Asynchronous I/O latency to a solid-state disk greatly increased
between the 2.6.32 and 3.0 kernels. By removing the plug from
do_io_submit(), we observed a 34% improvement in the I/O latency.
Unfortunately, at this level, we don't know if the request is to
a rotating disk or not.
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: linux-aio@kvack.org
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
diff --git a/fs/aio.c b/fs/aio.c
index 78c514c..d131a2c 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1696,7 +1696,6 @@ long do_io_submit(aio_context_t ctx_id, long nr,
struct kioctx *ctx;
long ret = 0;
int i = 0;
- struct blk_plug plug;
struct kiocb_batch batch;
if (unlikely(nr < 0))
@@ -1716,8 +1715,6 @@ long do_io_submit(aio_context_t ctx_id, long nr,
kiocb_batch_init(&batch, nr);
- blk_start_plug(&plug);
-
/*
* AKPM: should this return a partial result if some of the IOs were
* successfully submitted?
@@ -1740,7 +1737,6 @@ long do_io_submit(aio_context_t ctx_id, long nr,
if (ret)
break;
}
- blk_finish_plug(&plug);
kiocb_batch_free(&batch);
put_ioctx(ctx);
next reply other threads:[~2011-12-13 21:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 21:44 Dave Kleikamp [this message]
2011-12-13 22:18 ` [PATCH] AIO: Don't plug the I/O queue in do_io_submit() Jeff Moyer
2011-12-13 23:26 ` Dave Kleikamp
2011-12-14 20:58 ` Chris Mason
2011-12-16 14:45 ` Jeff Moyer
2011-12-15 1:09 ` Shaohua Li
2011-12-15 16:15 ` Jens Axboe
2011-12-15 16:40 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE7C74D.1020306@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=ak@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=chris.mason@oracle.com \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).