From: Chris Metcalf <cmetcalf@tilera.com>
To: roel <roel.kluin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch/tile: misplaced parens near likely
Date: Wed, 14 Dec 2011 11:36:26 -0500 [thread overview]
Message-ID: <4EE8D08A.9070202@tilera.com> (raw)
In-Reply-To: <4EE6815E.8090905@gmail.com>
On 12/12/2011 5:34 PM, roel wrote:
> Parentheses were missing.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Thanks, I'll take this into the tile tree.
> ---
> arch/tile/lib/spinlock_32.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> This is what it should be, right?
>
> diff --git a/arch/tile/lib/spinlock_32.c b/arch/tile/lib/spinlock_32.c
> index cb0999f..b16ac49 100644
> --- a/arch/tile/lib/spinlock_32.c
> +++ b/arch/tile/lib/spinlock_32.c
> @@ -144,7 +144,7 @@ void arch_read_unlock(arch_rwlock_t *rwlock)
> for (;;) {
> __insn_mtspr(SPR_INTERRUPT_CRITICAL_SECTION, 1);
> val = __insn_tns((int *)&rwlock->lock);
> - if (likely(val & 1) == 0) {
> + if (likely((val & 1) == 0)) {
> rwlock->lock = val - (1 << _RD_COUNT_SHIFT);
> __insn_mtspr(SPR_INTERRUPT_CRITICAL_SECTION, 0);
> break;
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
prev parent reply other threads:[~2011-12-14 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 22:34 [PATCH] arch/tile: misplaced parens near likely roel
2011-12-14 16:36 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE8D08A.9070202@tilera.com \
--to=cmetcalf@tilera.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox