From: "H. Peter Anvin" <hpa@zytor.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Mike Waychison <mikew@google.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 3/4] EFI: Add support for variables longer than 1024 bytes
Date: Wed, 14 Dec 2011 14:44:34 -0800 [thread overview]
Message-ID: <4EE926D2.3030803@zytor.com> (raw)
In-Reply-To: <20111214223950.GA29264@srcf.ucam.org>
On 12/14/2011 02:39 PM, Matthew Garrett wrote:
>
>> We need to be careful here. The store_raw ABI is broken, in the sense
>> that the ABI from compat mode differs from that in 32bit mode (there
>> is a long in the efi_variable structure which changes the offsets). I
>> don't know how to fix it properly and still maintain proper ABI
>> compatibility.
>
> True.
>
>> What are your thoughts on _not_ wrapping efi_variable with
>> extended_efi_variable, and instead just using a
>> "internal_efi_variable" structure that we copy stuff into/outof. I
>> think that would make the memory management for dealing with the
>> different sizes a lot easier to follow.
>
> Hm. I think that'd only work if we expose a new interface. Writes would
> be easy enough to handle, but reads still need to work for old apps.
>
Would making the old ABI readonly and add a new write interface resolve
the problem with compat mode?
-hpa
next prev parent reply other threads:[~2011-12-14 22:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 21:06 Update UEFI variable support Matthew Garrett
2011-12-14 21:06 ` [PATCH 1/4] uefi: Populate runtime_version Matthew Garrett
2011-12-14 21:06 ` [PATCH 2/4] efi: Only create sysfs entries while booting or running Matthew Garrett
2011-12-14 21:32 ` Mike Waychison
2011-12-14 21:06 ` [PATCH 3/4] EFI: Add support for variables longer than 1024 bytes Matthew Garrett
2011-12-14 22:14 ` Mike Waychison
2011-12-14 22:39 ` Matthew Garrett
2011-12-14 22:44 ` H. Peter Anvin [this message]
2011-12-14 22:57 ` Matthew Garrett
2011-12-14 22:58 ` H. Peter Anvin
2011-12-15 15:44 ` Matthew Garrett
2011-12-14 22:57 ` Mike Waychison
2011-12-14 23:00 ` H. Peter Anvin
2011-12-14 23:06 ` Mike Waychison
2011-12-14 23:22 ` H. Peter Anvin
2011-12-14 23:24 ` Mike Waychison
2011-12-15 15:43 ` Matthew Garrett
2011-12-15 15:46 ` H. Peter Anvin
2011-12-15 15:48 ` Matthew Garrett
2011-12-14 21:06 ` [PATCH 4/4] EFI: Add support for QueryVariableInfo() call Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE926D2.3030803@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mjg59@srcf.ucam.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox