From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758390Ab1LNXAt (ORCPT ); Wed, 14 Dec 2011 18:00:49 -0500 Received: from terminus.zytor.com ([198.137.202.10]:34638 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758361Ab1LNXAs (ORCPT ); Wed, 14 Dec 2011 18:00:48 -0500 Message-ID: <4EE92A97.5080606@zytor.com> Date: Wed, 14 Dec 2011 15:00:39 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: Mike Waychison CC: Matthew Garrett , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 3/4] EFI: Add support for variables longer than 1024 bytes References: <1323896791-10858-1-git-send-email-mjg@redhat.com> <1323896791-10858-4-git-send-email-mjg@redhat.com> <20111214223950.GA29264@srcf.ucam.org> In-Reply-To: X-Enigmail-Version: 1.3.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14/2011 02:57 PM, Mike Waychison wrote: > > Well,l we could *not* support returning all the data field for > datasize > 1024, and simply truncate the field. We are limited by > PAGE_SIZE by sysfs here anyway (so we don't really want to have a > variable size memcpy in efivar_show_raw). > That may be the biggest reason to avoid sysfs. As far as I know sysfs doesn't allow seq_file to be used. -hpa