From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759984Ab1LPCHR (ORCPT ); Thu, 15 Dec 2011 21:07:17 -0500 Received: from mx2.parallels.com ([64.131.90.16]:38719 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084Ab1LPCHP (ORCPT ); Thu, 15 Dec 2011 21:07:15 -0500 Message-ID: <4EEAA7AA.3030209@parallels.com> Date: Fri, 16 Dec 2011 06:06:34 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: KAMEZAWA Hiroyuki CC: , , , , Eric Dumazet , Stephen Rothwell Subject: Re: [PATCH 2/2] Explicitly call tcp creation and init from memcontrol.c References: <1323941672-14324-1-git-send-email-glommer@parallels.com> <1323941672-14324-3-git-send-email-glommer@parallels.com> <20111216011316.8d58bc8f.kamezawa.hiroyu@jp.fujitsu.com> <20111216072050.4f49ac66.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20111216072050.4f49ac66.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [83.149.8.193] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/16/2011 02:20 AM, KAMEZAWA Hiroyuki wrote: > On Fri, 16 Dec 2011 01:13:16 +0900 > KAMEZAWA Hiroyuki wrote: > >> On Thu, 15 Dec 2011 13:34:32 +0400 >> Glauber Costa wrote: >> >>> Walking the proto_list holds a read_lock, which prevents us from doing >>> allocations. Splitting the tcp create function into create + init is >>> good, but it is not enough since create_files will do allocations as well >>> (dentry ones, mostly). >>> >>> Since this does not involve any protocol state, I propose we call the tcp >>> functions explicitly from memcontrol.c >>> >>> With this, we lose by now the ability of doing cgroup memcontrol for >>> protocols that are loaded as modules. But at least the ones I have in mind >>> won't really need it (tcp_ipv6 being the only one, but it uses the same data >>> structures as tcp_ipv4). So I believe this to be the simpler solution to this >>> problem. >>> >>> Signed-off-by: Glauber Costa >>> CC: Hiroyouki Kamezawa >>> CC: David S. Miller >>> CC: Eric Dumazet >>> CC: Stephen Rothwell >> >> Could you remake the patch onto the 'latest' linux-next ? >> As Dave mentioned, some bandaids are already applied and this patch hunks. > > Applied patches by hand and did small test for hours. > seems good. > > Reviewed-by: KAMEZAWA Hiroyuki > Kame, Thanks. But see Dave's answer to this: He'd like me to follow a slightly different approach (I've attached a patch earlier)