From: Frank Rowand <frank.rowand@am.sony.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
<rostedt@goodmis.org>
Cc: <stable-rt@vger.kernel.org>
Subject: adding cc to stable-rt: [PATCH] PREEMPT_RT_FULL: ARM context switch needs IRQs enabled
Date: Thu, 15 Dec 2011 20:07:06 -0800 [thread overview]
Message-ID: <4EEAC3EA.3070202@am.sony.com> (raw)
ARMv6 and later have VIPT caches and the TLBs are tagged with an ASID
(application specific ID). The number of ASIDs is limited to 256 and
the allocation algorithm requires IPIs when all the ASIDs have been
used. The IPIs require interrupts enabled during context switch for
deadlock avoidance.
The RT patch mm-protect-activate-switch-mm.patch disables irqs around
activate_mm() and switch_mm(), which are the portion of the ARMv6
context switch that require interrupts enabled.
The solution for the ARMv6 processors could be to _not_ disable irqs.
A more conservative solution is to provide the same environment that
the scheduler provides, that is preempt_disable(). This is more
resilient for possible future changes to the ARM context switch code
that is not aware of the RT patches.
This patch will conflict slightly with Catalin's patch set to remove
__ARCH_WANT_INTERRUPTS_ON_CTXSW, when that is accepted:
http://lkml.indiana.edu/hypermail/linux/kernel/1111.3/01893.html
When Catalin's patch set is accepted, this RT patch will need to reverse
the change in patch 6 to arch/arm/include/asm/system.h:
-#ifndef CONFIG_CPU_HAS_ASID
-#define __ARCH_WANT_INTERRUPTS_ON_CTXSW
-#endif
Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
---
fs/exec.c | 8 8 + 0 - 0 !
mm/mmu_context.c | 8 8 + 0 - 0 !
2 files changed, 16 insertions(+)
Index: b/fs/exec.c
===================================================================
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -837,12 +837,20 @@ static int exec_mmap(struct mm_struct *m
}
}
task_lock(tsk);
+#ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW
+ preempt_disable();
+#else
local_irq_disable_rt();
+#endif
active_mm = tsk->active_mm;
tsk->mm = mm;
tsk->active_mm = mm;
activate_mm(active_mm, mm);
+#ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW
+ preempt_enable();
+#else
local_irq_enable_rt();
+#endif
task_unlock(tsk);
arch_pick_mmap_layout(mm);
if (old_mm) {
Index: b/mm/mmu_context.c
===================================================================
--- a/mm/mmu_context.c
+++ b/mm/mmu_context.c
@@ -26,7 +26,11 @@ void use_mm(struct mm_struct *mm)
struct task_struct *tsk = current;
task_lock(tsk);
+#ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW
+ preempt_disable();
+#else
local_irq_disable_rt();
+#endif
active_mm = tsk->active_mm;
if (active_mm != mm) {
atomic_inc(&mm->mm_count);
@@ -34,7 +38,11 @@ void use_mm(struct mm_struct *mm)
}
tsk->mm = mm;
switch_mm(active_mm, mm, tsk);
+#ifdef __ARCH_WANT_INTERRUPTS_ON_CTXSW
+ preempt_enable();
+#else
local_irq_enable_rt();
+#endif
task_unlock(tsk);
if (active_mm != mm)
reply other threads:[~2011-12-16 4:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEAC3EA.3070202@am.sony.com \
--to=frank.rowand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable-rt@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox