* [PATCH] atmel ac97c: using software reset instead hardware reset if not available
@ 2011-11-23 10:05 voice
2011-11-24 10:44 ` Nicolas Ferre
2011-12-15 13:04 ` Nicolas Ferre
0 siblings, 2 replies; 7+ messages in thread
From: voice @ 2011-11-23 10:05 UTC (permalink / raw)
To: linux-kernel, linux-sound; +Cc: Nicolas.Ferre, JM.Lin, Hong.Xu, voice
Using software reset instead hardware reset if not available
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
sound/atmel/ac97c.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index 6e5adde..73516f6 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -899,6 +899,10 @@ static void atmel_ac97c_reset(struct atmel_ac97c *chip)
/* AC97 v2.2 specifications says minimum 1 us. */
udelay(2);
gpio_set_value(chip->reset_pin, 1);
+ } else {
+ ac97c_writel(chip, MR, AC97C_MR_WRST | AC97C_MR_ENA);
+ udelay(2);
+ ac97c_writel(chip, MR, AC97C_MR_ENA);
}
}
--
1.6.3.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] atmel ac97c: using software reset instead hardware reset if not available
2011-11-23 10:05 [PATCH] atmel ac97c: using software reset instead hardware reset if not available voice
@ 2011-11-24 10:44 ` Nicolas Ferre
2011-12-15 13:04 ` Nicolas Ferre
1 sibling, 0 replies; 7+ messages in thread
From: Nicolas Ferre @ 2011-11-24 10:44 UTC (permalink / raw)
To: voice; +Cc: linux-kernel, linux-sound, JM.Lin, Hong.Xu
On 11/23/2011 11:05 AM, voice :
> Using software reset instead hardware reset if not available
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
You may need to sent it to the sound subsystem mailing-list and maintainers.
Anyway, I let you follow this patch... As it is a fixup and will benefit
to existing platforms, I think that it can make its way to mainline
during 3.2 phase.
Best regards,
> ---
> sound/atmel/ac97c.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index 6e5adde..73516f6 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -899,6 +899,10 @@ static void atmel_ac97c_reset(struct atmel_ac97c *chip)
> /* AC97 v2.2 specifications says minimum 1 us. */
> udelay(2);
> gpio_set_value(chip->reset_pin, 1);
> + } else {
> + ac97c_writel(chip, MR, AC97C_MR_WRST | AC97C_MR_ENA);
> + udelay(2);
> + ac97c_writel(chip, MR, AC97C_MR_ENA);
> }
> }
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] atmel ac97c: using software reset instead hardware reset if not available
2011-11-23 10:05 [PATCH] atmel ac97c: using software reset instead hardware reset if not available voice
2011-11-24 10:44 ` Nicolas Ferre
@ 2011-12-15 13:04 ` Nicolas Ferre
2011-12-16 1:52 ` Shen, Voice
1 sibling, 1 reply; 7+ messages in thread
From: Nicolas Ferre @ 2011-12-15 13:04 UTC (permalink / raw)
To: voice; +Cc: linux-kernel, linux-sound, JM.Lin, Hong.Xu
On 11/23/2011 11:05 AM, voice :
> Using software reset instead hardware reset if not available
Ping?
Can you please tell me what is the status of this fix? Will it go
upstream for 3.3?
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> sound/atmel/ac97c.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index 6e5adde..73516f6 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -899,6 +899,10 @@ static void atmel_ac97c_reset(struct atmel_ac97c *chip)
> /* AC97 v2.2 specifications says minimum 1 us. */
> udelay(2);
> gpio_set_value(chip->reset_pin, 1);
> + } else {
> + ac97c_writel(chip, MR, AC97C_MR_WRST | AC97C_MR_ENA);
> + udelay(2);
> + ac97c_writel(chip, MR, AC97C_MR_ENA);
> }
> }
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH] atmel ac97c: using software reset instead hardware reset if not available
2011-12-15 13:04 ` Nicolas Ferre
@ 2011-12-16 1:52 ` Shen, Voice
2011-12-16 8:39 ` Nicolas Ferre
0 siblings, 1 reply; 7+ messages in thread
From: Shen, Voice @ 2011-12-16 1:52 UTC (permalink / raw)
To: Ferre, Nicolas; +Cc: linux-kernel, linux-sound, Lin, JM, Xu, Hong
Hi Nicolas,
No one response for this.
Would you please merge it?
Thanks
Best Regards,
Voice Shen
-----Original Message-----
From: Nicolas Ferre [mailto:nicolas.ferre@atmel.com]
Sent: Thursday, December 15, 2011 21:04 voice
To: Shen, Voice
Cc: linux-kernel@vger.kernel.org; linux-sound@vger.kernel.org; Lin, JM;
Xu, Hong
Subject: Re: [PATCH] atmel ac97c: using software reset instead hardware
reset if not available
On 11/23/2011 11:05 AM, voice :
> Using software reset instead hardware reset if not available
Ping?
Can you please tell me what is the status of this fix? Will it go
upstream for 3.3?
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> sound/atmel/ac97c.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index 6e5adde..73516f6 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -899,6 +899,10 @@ static void atmel_ac97c_reset(struct atmel_ac97c
*chip)
> /* AC97 v2.2 specifications says minimum 1 us. */
> udelay(2);
> gpio_set_value(chip->reset_pin, 1);
> + } else {
> + ac97c_writel(chip, MR, AC97C_MR_WRST | AC97C_MR_ENA);
> + udelay(2);
> + ac97c_writel(chip, MR, AC97C_MR_ENA);
> }
> }
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] atmel ac97c: using software reset instead hardware reset if not available
2011-12-16 1:52 ` Shen, Voice
@ 2011-12-16 8:39 ` Nicolas Ferre
0 siblings, 0 replies; 7+ messages in thread
From: Nicolas Ferre @ 2011-12-16 8:39 UTC (permalink / raw)
To: Shen, Voice; +Cc: linux-kernel, linux-sound, Lin, JM, Xu, Hong
On 12/16/2011 02:52 AM, Shen, Voice :
> Hi Nicolas,
> No one response for this.
> Would you please merge it?
Unfortunately I cannot.
You will have to make sure that the *sound* maintainer is taking your
patch into account. It can take several iterations but you must be sure
that your work is included into maintainer's git tree.
Good luck... Bye,
> -----Original Message-----
> From: Nicolas Ferre [mailto:nicolas.ferre@atmel.com]
> Sent: Thursday, December 15, 2011 21:04 voice
> To: Shen, Voice
> Cc: linux-kernel@vger.kernel.org; linux-sound@vger.kernel.org; Lin, JM;
> Xu, Hong
> Subject: Re: [PATCH] atmel ac97c: using software reset instead hardware
> reset if not available
>
> On 11/23/2011 11:05 AM, voice :
>> Using software reset instead hardware reset if not available
>
> Ping?
> Can you please tell me what is the status of this fix? Will it go
> upstream for 3.3?
>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> sound/atmel/ac97c.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
>> index 6e5adde..73516f6 100644
>> --- a/sound/atmel/ac97c.c
>> +++ b/sound/atmel/ac97c.c
>> @@ -899,6 +899,10 @@ static void atmel_ac97c_reset(struct atmel_ac97c
> *chip)
>> /* AC97 v2.2 specifications says minimum 1 us. */
>> udelay(2);
>> gpio_set_value(chip->reset_pin, 1);
>> + } else {
>> + ac97c_writel(chip, MR, AC97C_MR_WRST | AC97C_MR_ENA);
>> + udelay(2);
>> + ac97c_writel(chip, MR, AC97C_MR_ENA);
>> }
>> }
>>
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] atmel ac97c: using software reset instead hardware reset if not available
@ 2011-12-19 9:57 voice
2011-12-19 10:28 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: voice @ 2011-12-19 9:57 UTC (permalink / raw)
To: tiwai
Cc: linux-kernel, linux-sound, alsa-devel, nicolas.ferre,
Hans-Christian.Egtvedt, jm.lin, hong.xu, voice
Using software reset instead hardware reset if not available
Signed-off-by: Bo Shen <voice.shen@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
sound/atmel/ac97c.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index 6e5adde..73516f6 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -899,6 +899,10 @@ static void atmel_ac97c_reset(struct atmel_ac97c *chip)
/* AC97 v2.2 specifications says minimum 1 us. */
udelay(2);
gpio_set_value(chip->reset_pin, 1);
+ } else {
+ ac97c_writel(chip, MR, AC97C_MR_WRST | AC97C_MR_ENA);
+ udelay(2);
+ ac97c_writel(chip, MR, AC97C_MR_ENA);
}
}
--
1.6.3.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] atmel ac97c: using software reset instead hardware reset if not available
2011-12-19 9:57 voice
@ 2011-12-19 10:28 ` Takashi Iwai
0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2011-12-19 10:28 UTC (permalink / raw)
To: voice
Cc: linux-kernel, linux-sound, alsa-devel, nicolas.ferre,
Hans-Christian.Egtvedt, jm.lin, hong.xu
At Mon, 19 Dec 2011 17:57:52 +0800,
voice wrote:
>
> Using software reset instead hardware reset if not available
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Applied now. Thanks.
Takashi
> ---
> sound/atmel/ac97c.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index 6e5adde..73516f6 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -899,6 +899,10 @@ static void atmel_ac97c_reset(struct atmel_ac97c *chip)
> /* AC97 v2.2 specifications says minimum 1 us. */
> udelay(2);
> gpio_set_value(chip->reset_pin, 1);
> + } else {
> + ac97c_writel(chip, MR, AC97C_MR_WRST | AC97C_MR_ENA);
> + udelay(2);
> + ac97c_writel(chip, MR, AC97C_MR_ENA);
> }
> }
>
> --
> 1.6.3.3
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-12-19 10:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-23 10:05 [PATCH] atmel ac97c: using software reset instead hardware reset if not available voice
2011-11-24 10:44 ` Nicolas Ferre
2011-12-15 13:04 ` Nicolas Ferre
2011-12-16 1:52 ` Shen, Voice
2011-12-16 8:39 ` Nicolas Ferre
-- strict thread matches above, loose matches on Subject: below --
2011-12-19 9:57 voice
2011-12-19 10:28 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox