From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@suse.de>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] usb: musb: fix pm_runtime mismatch
Date: Fri, 16 Dec 2011 14:46:26 +0400 [thread overview]
Message-ID: <4EEB2182.6040508@mvista.com> (raw)
In-Reply-To: <1323988934-11350-1-git-send-email-felipe.contreras@gmail.com>
Hello.
On 16-12-2011 2:42, Felipe Contreras wrote:
> In musb_init_controller() there's a pm_runtime_put(), but there's no
> pm_runtime_get(), which creates a mismatch that causes the driver to
> sleep when it shouldn't.
> This was introduced in 7acc619, but it wasn't triggered until 18a2689
> was merged to Linus' branch at point 6899608.
Please also specify the summaries for the commits you're mentioning.
> However, it seems most of the time this is used in a way that keeps the
> counter above 0, so nobody noticed. Also, it seems to depend on the
> configuration used.
> I found the problem by loading isp1704_charger before any usb gadgets:
> http://article.gmane.org/gmane.linux.kernel/1226122
> All versions after 2.6.39 are affected.
> Cc: stable@vger.kernel.org
> Signed-off-by: Felipe Contreras<felipe.contreras@gmail.com>
WBR, Sergei
prev parent reply other threads:[~2011-12-16 10:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 22:42 [PATCH] usb: musb: fix pm_runtime mismatch Felipe Contreras
2011-12-15 23:01 ` Felipe Balbi
2011-12-15 23:31 ` Felipe Contreras
2011-12-15 23:50 ` Felipe Balbi
2011-12-16 1:13 ` Felipe Contreras
2011-12-16 1:38 ` Felipe Balbi
2011-12-19 19:39 ` Felipe Contreras
2011-12-15 23:02 ` Greg KH
2011-12-15 23:11 ` Greg KH
2011-12-15 23:52 ` Felipe Balbi
2011-12-16 10:46 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEB2182.6040508@mvista.com \
--to=sshtylyov@mvista.com \
--cc=balbi@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=gregkh@suse.de \
--cc=jarkko.nikula@bitmer.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox