From: Clemens Ladisch <clemens@ladisch.de>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: alsa-devel@alsa-project.org, Tom Walder <tom.walder@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] Jabra SPEAK 410 USB - no audio playback
Date: Fri, 16 Dec 2011 14:49:05 +0100 [thread overview]
Message-ID: <4EEB4C51.4010205@ladisch.de> (raw)
In-Reply-To: <20111210194539.GF16692@amd.home.annexia.org>
Richard W.M. Jones wrote:
> The attached patch fixes USB audio support for the Jabra SPEAK 410 USB.
>
> The problem, as I understand it, is that the device contains a
> Class-Specific Endpoint (CS_ENDPOINT) descriptor before the Endpoint
> (ENDPOINT) descriptor. The USB code all assumes that CS_ENDPOINT can
> only appear after ENDPOINT. Therefore the USB code divides up the
> interface descriptor into "stuff before ENDPOINT" (in
> interface->extra) and "stuff after ENDPOINT" (in
> interface->endpoint[0]->extra). For this device, this division does
> not work.
>
> The solution (which is a hack ...) is to also search interface->extra
> looking for the missing descriptor.
The patch looks good. Please run it through checkpatch.pl and provice
a Signed-off-by tag (see Documentation/SubmittingPatches).
Regards,
Clemens
next prev parent reply other threads:[~2011-12-16 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111210142419.GC16692@amd.home.annexia.org>
2011-12-10 19:45 ` [PATCH] Jabra SPEAK 410 USB - no audio playback Richard W.M. Jones
2011-12-13 22:14 ` [alsa-devel] " Richard W.M. Jones
2011-12-16 13:49 ` Clemens Ladisch [this message]
2011-12-16 19:12 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEB4C51.4010205@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjones@redhat.com \
--cc=tom.walder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox