From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jacob Shin <jacob.shin@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
"Herrmann3, Andreas" <Andreas.Herrmann3@amd.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: [PATCH 1/1] x86: Exclude E820_RESERVED regions and memory holes above 4 GB from direct mapping.
Date: Fri, 16 Dec 2011 16:57:32 -0800 [thread overview]
Message-ID: <4EEBE8FC.80309@zytor.com> (raw)
In-Reply-To: <CAE9FiQUNwK5=Nos7Ce_DS1aSXgf0WNUgE=5HXnt4E01JWYbWjQ@mail.gmail.com>
On 12/16/2011 12:59 PM, Yinghai Lu wrote:
> On Fri, Dec 16, 2011 at 10:32 AM, H. Peter Anvin <hpa@zytor.com> wrote:
>>
>> Well, there are two options for memory hotplug: either we always leave
>> address space that can be used for memory hotplug mapped at all times, or we
>> need to track it anyway. Either way we need to know where there regions
>> are. Am I correct that right now we always map memory hotpluggable regions,
>> being below the top pfn?
>
> in arch/x86/mm/init_64.c::arch_add_memory()
> it will call init_memory_mapping to map new added memory.
> and will update max_pfn_mapped, max-pfn, max_low_pfn.
>
OK, so that would seem to match the invariant that all the memory blocks
which are RAM have mappings, and the ones that don't don't have them, or
is that violated elsewhere? Either way, the same notion applies -- we
should either leverage an existing range map or have a new one, but
there is nothing magic about holes above or below the 4 GiB boundary;
the only "magic" is for 32 bits the HIGHMEM boundary and < 1 MiB
(because of the fixed MTRRs).
-hpa
next prev parent reply other threads:[~2011-12-17 0:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 21:15 [PATCH 1/1] x86: Exclude E820_RESERVED regions and memory holes above 4 GB from direct mapping Jacob Shin
2011-10-20 21:28 ` Andi Kleen
2011-10-20 21:30 ` H. Peter Anvin
2011-10-20 21:32 ` H. Peter Anvin
2011-10-20 22:10 ` Jacob Shin
2011-10-20 22:43 ` H. Peter Anvin
2011-10-20 22:20 ` H. Peter Anvin
2011-10-20 22:26 ` Jacob Shin
2011-12-14 22:42 ` H. Peter Anvin
2011-12-14 23:14 ` Jacob Shin
2011-12-16 16:20 ` Jacob Shin
2011-12-16 17:42 ` Yinghai Lu
2011-12-16 17:54 ` H. Peter Anvin
2011-12-16 18:29 ` Yinghai Lu
2011-12-16 18:32 ` H. Peter Anvin
2011-12-16 20:59 ` Yinghai Lu
2011-12-17 0:57 ` H. Peter Anvin [this message]
2012-10-17 19:17 ` [tip:x86/urgent] " tip-bot for Jacob Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEBE8FC.80309@zytor.com \
--to=hpa@zytor.com \
--cc=Andreas.Herrmann3@amd.com \
--cc=jacob.shin@amd.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox