* [PATCH] scsi_dh: Fix return value of scsi_dh_attach() @ 2011-11-17 23:34 Richard Weinberger 2011-12-18 14:43 ` Richard Weinberger 0 siblings, 1 reply; 6+ messages in thread From: Richard Weinberger @ 2011-11-17 23:34 UTC (permalink / raw) To: JBottomley; +Cc: linux-scsi, linux-kernel, Richard Weinberger scsi_dh_attach() should return a negative value on error. Signed-off-by: Richard Weinberger <richard@nod.at> --- include/scsi/scsi_dh.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/scsi/scsi_dh.h b/include/scsi/scsi_dh.h index e3f2db2..e07ab10 100644 --- a/include/scsi/scsi_dh.h +++ b/include/scsi/scsi_dh.h @@ -74,7 +74,7 @@ static inline int scsi_dh_handler_exist(const char *name) } static inline int scsi_dh_attach(struct request_queue *req, const char *name) { - return SCSI_DH_NOSYS; + return -SCSI_DH_NOSYS; } static inline void scsi_dh_detach(struct request_queue *q) { -- 1.7.7.3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi_dh: Fix return value of scsi_dh_attach() 2011-11-17 23:34 [PATCH] scsi_dh: Fix return value of scsi_dh_attach() Richard Weinberger @ 2011-12-18 14:43 ` Richard Weinberger 2011-12-18 14:45 ` James Bottomley 0 siblings, 1 reply; 6+ messages in thread From: Richard Weinberger @ 2011-12-18 14:43 UTC (permalink / raw) To: JBottomley; +Cc: linux-scsi, linux-kernel [-- Attachment #1: Type: text/plain, Size: 805 bytes --] Am 18.11.2011 00:34, schrieb Richard Weinberger: > scsi_dh_attach() should return a negative value on error. > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > include/scsi/scsi_dh.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/scsi/scsi_dh.h b/include/scsi/scsi_dh.h > index e3f2db2..e07ab10 100644 > --- a/include/scsi/scsi_dh.h > +++ b/include/scsi/scsi_dh.h > @@ -74,7 +74,7 @@ static inline int scsi_dh_handler_exist(const char *name) > } > static inline int scsi_dh_attach(struct request_queue *req, const char *name) > { > - return SCSI_DH_NOSYS; > + return -SCSI_DH_NOSYS; > } > static inline void scsi_dh_detach(struct request_queue *q) > { James, can you please pickup this patch? Thanks, //richard [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi_dh: Fix return value of scsi_dh_attach() 2011-12-18 14:43 ` Richard Weinberger @ 2011-12-18 14:45 ` James Bottomley 2011-12-18 14:53 ` Richard Weinberger 0 siblings, 1 reply; 6+ messages in thread From: James Bottomley @ 2011-12-18 14:45 UTC (permalink / raw) To: Richard Weinberger; +Cc: linux-scsi, linux-kernel On Sun, 2011-12-18 at 15:43 +0100, Richard Weinberger wrote: > Am 18.11.2011 00:34, schrieb Richard Weinberger: > > scsi_dh_attach() should return a negative value on error. > > > > Signed-off-by: Richard Weinberger <richard@nod.at> > > --- > > include/scsi/scsi_dh.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/include/scsi/scsi_dh.h b/include/scsi/scsi_dh.h > > index e3f2db2..e07ab10 100644 > > --- a/include/scsi/scsi_dh.h > > +++ b/include/scsi/scsi_dh.h > > @@ -74,7 +74,7 @@ static inline int scsi_dh_handler_exist(const char *name) > > } > > static inline int scsi_dh_attach(struct request_queue *req, const char *name) > > { > > - return SCSI_DH_NOSYS; > > + return -SCSI_DH_NOSYS; > > } > > static inline void scsi_dh_detach(struct request_queue *q) > > { > > James, > > can you please pickup this patch? It still needs an ack from rdac people (other one just got overlooked). James ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi_dh: Fix return value of scsi_dh_attach() 2011-12-18 14:45 ` James Bottomley @ 2011-12-18 14:53 ` Richard Weinberger 2011-12-19 11:59 ` Hannes Reinecke 0 siblings, 1 reply; 6+ messages in thread From: Richard Weinberger @ 2011-12-18 14:53 UTC (permalink / raw) To: James Bottomley; +Cc: linux-scsi, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1145 bytes --] Am 18.12.2011 15:45, schrieb James Bottomley: > On Sun, 2011-12-18 at 15:43 +0100, Richard Weinberger wrote: >> Am 18.11.2011 00:34, schrieb Richard Weinberger: >>> scsi_dh_attach() should return a negative value on error. >>> >>> Signed-off-by: Richard Weinberger <richard@nod.at> >>> --- >>> include/scsi/scsi_dh.h | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/include/scsi/scsi_dh.h b/include/scsi/scsi_dh.h >>> index e3f2db2..e07ab10 100644 >>> --- a/include/scsi/scsi_dh.h >>> +++ b/include/scsi/scsi_dh.h >>> @@ -74,7 +74,7 @@ static inline int scsi_dh_handler_exist(const char *name) >>> } >>> static inline int scsi_dh_attach(struct request_queue *req, const char *name) >>> { >>> - return SCSI_DH_NOSYS; >>> + return -SCSI_DH_NOSYS; >>> } >>> static inline void scsi_dh_detach(struct request_queue *q) >>> { >> >> James, >> >> can you please pickup this patch? > > It still needs an ack from rdac people (other one just got overlooked). > Who are the rdac people? I sent the patch to all addresses reported by get_maintainers.pl. Thanks, //richard [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi_dh: Fix return value of scsi_dh_attach() 2011-12-18 14:53 ` Richard Weinberger @ 2011-12-19 11:59 ` Hannes Reinecke 2011-12-19 12:40 ` Richard Weinberger 0 siblings, 1 reply; 6+ messages in thread From: Hannes Reinecke @ 2011-12-19 11:59 UTC (permalink / raw) To: Richard Weinberger; +Cc: James Bottomley, linux-scsi, linux-kernel On 12/18/2011 03:53 PM, Richard Weinberger wrote: > Am 18.12.2011 15:45, schrieb James Bottomley: >> On Sun, 2011-12-18 at 15:43 +0100, Richard Weinberger wrote: >>> Am 18.11.2011 00:34, schrieb Richard Weinberger: >>>> scsi_dh_attach() should return a negative value on error. >>>> >>>> Signed-off-by: Richard Weinberger <richard@nod.at> >>>> --- >>>> include/scsi/scsi_dh.h | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/include/scsi/scsi_dh.h b/include/scsi/scsi_dh.h >>>> index e3f2db2..e07ab10 100644 >>>> --- a/include/scsi/scsi_dh.h >>>> +++ b/include/scsi/scsi_dh.h >>>> @@ -74,7 +74,7 @@ static inline int scsi_dh_handler_exist(const char *name) >>>> } >>>> static inline int scsi_dh_attach(struct request_queue *req, const char *name) >>>> { >>>> - return SCSI_DH_NOSYS; >>>> + return -SCSI_DH_NOSYS; >>>> } >>>> static inline void scsi_dh_detach(struct request_queue *q) >>>> { >>> >>> James, >>> >>> can you please pickup this patch? >> >> It still needs an ack from rdac people (other one just got overlooked). >> > > Who are the rdac people? > I sent the patch to all addresses reported by get_maintainers.pl. > Nack. This patch is wrong. scsi_dh_attach() (and, incidentally, scsi_dh_set_params()) should return a standard error value. SCSI_DH_XXX are internal to device_handler and should never see the light of day. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi_dh: Fix return value of scsi_dh_attach() 2011-12-19 11:59 ` Hannes Reinecke @ 2011-12-19 12:40 ` Richard Weinberger 0 siblings, 0 replies; 6+ messages in thread From: Richard Weinberger @ 2011-12-19 12:40 UTC (permalink / raw) To: Hannes Reinecke; +Cc: James Bottomley, linux-scsi, linux-kernel Hannes, On 19.12.2011 12:59, Hannes Reinecke wrote: > Nack. > > This patch is wrong. > > scsi_dh_attach() (and, incidentally, scsi_dh_set_params()) should > return a standard error value. SCSI_DH_XXX are internal to > device_handler and should never see the light of day. > Thanks for your feedback. Both scsi_dh_attach() and scsi_dh_set_params() should return -ENODEV, right? Thanks, //richard ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-19 12:40 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-11-17 23:34 [PATCH] scsi_dh: Fix return value of scsi_dh_attach() Richard Weinberger 2011-12-18 14:43 ` Richard Weinberger 2011-12-18 14:45 ` James Bottomley 2011-12-18 14:53 ` Richard Weinberger 2011-12-19 11:59 ` Hannes Reinecke 2011-12-19 12:40 ` Richard Weinberger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).