From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753213Ab1LTK0m (ORCPT <rfc822;w@1wt.eu>);
	Tue, 20 Dec 2011 05:26:42 -0500
Received: from mx2.parallels.com ([64.131.90.16]:35716 "EHLO mx2.parallels.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752070Ab1LTK0e (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 20 Dec 2011 05:26:34 -0500
Message-ID: <4EF062B1.3030401@parallels.com>
Date: Tue, 20 Dec 2011 14:25:53 +0400
From: Glauber Costa <glommer@parallels.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0
MIME-Version: 1.0
To: Stanislav Kinsbursky <skinsbursky@parallels.com>
CC: <Trond.Myklebust@netapp.com>, <linux-nfs@vger.kernel.org>,
        <xemul@parallels.com>, <neilb@suse.de>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bfields@fieldses.org>,
        <davem@davemloft.net>, <devel@openvz.org>
Subject: Re: [Devel] [PATCH] SUNRPC: search for service transports in network
 namespace context
References: <20111220101419.5673.21926.stgit@localhost6.localdomain6>
In-Reply-To: <20111220101419.5673.21926.stgit@localhost6.localdomain6>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/20/2011 03:14 PM, Stanislav Kinsbursky wrote:
> Service transports are parametrized by network namespace. And thus lookup of
> transport instance have to take network namespace into account.
>
> Signed-off-by: Stanislav Kinsbursky<skinsbursky@parallels.com>
>
> ---
>   fs/lockd/svc.c                  |    2 +-
>   fs/nfsd/nfsctl.c                |    4 ++--
>   include/linux/sunrpc/svc_xprt.h |    3 ++-
>   net/sunrpc/svc_xprt.c           |    6 +++++-
>   4 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index c061b9a..ff379ff 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -193,7 +193,7 @@ static int create_lockd_listener(struct svc_serv *serv, const char *name,
>   {
>   	struct svc_xprt *xprt;
>
> -	xprt = svc_find_xprt(serv, name, family, 0);
> +	xprt = svc_find_xprt(serv, name,&init_net, family, 0);
>   	if (xprt == NULL)
>   		return svc_create_xprt(serv, name,&init_net, family, port,
>   						SVC_SOCK_DEFAULTS);

I might be missing something, but isn't it (at least part of it) already 
merged in commit fc5d00b04a3a58cac8620403dfe9f43f72578ec1 ?