From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752835Ab1LUJSY (ORCPT ); Wed, 21 Dec 2011 04:18:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14665 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752363Ab1LUJSV (ORCPT ); Wed, 21 Dec 2011 04:18:21 -0500 Message-ID: <4EF1A454.8070503@redhat.com> Date: Wed, 21 Dec 2011 11:18:12 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: "Liu, Jinsong" CC: Linus Torvalds , Alexey Zaytsev , Kernel development list , Jan Kiszka , Marcelo Tosatti , "Garrett D'Amore" Subject: Re: [Regression, bisected] a3e06bbe8445f57eb949e6474c5a9b30f24d2057: KVM: emulate lapic tsc deadline timer for guest" References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/20/2011 09:21 PM, Liu, Jinsong wrote: > Yes, my fault to say 'walk around' before knowing Alex's issue clearly. > > After Alex send his last email to clarify the situation, I have checked the bug. > Basically it caused from > 1. qemu didn't issue KVM_CREATE_IRQCHIP, hence irqchip_in_kernel(kvm) fail when setup vcpu lapic logic at kvm_arch_vcpu_init(); > 2. tsc deadline work based on vcpu lapic, hence break illumos; > > A fix is to update cpuid, as you said, setting it after KVM_CREATE_IRQCHIP. Wait, qemu set up a vcpu with TSC deadline timer in cpuid, but with userspace apic? Then it was clearly lying, since qemu doesn't implement the TSC deadline timer. > I just wonder is there any better solution? so I ask Alex his environment to setup at my side to do more test. > If you think kvm tsc deadline timer patch itself not clean, please tell me. > Alexey, did you use -cpu host? -- error compiling committee.c: too many arguments to function