From: Glauber Costa <glommer@parallels.com>
To: Glauber Costa <glommer@parallels.com>
Cc: <linux-kernel@vger.kernel.org>, <a.p.zijlstra@chello.nl>,
<pjt@google.com>, <devel@openvz.org>,
Michal Hocko <mhocko@suse.cz>, Dave Jones <davej@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Alexey Dobriyan <adobriyan@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] move get_idle_time , get_iowait_time to sched/core.c
Date: Fri, 23 Dec 2011 14:08:09 +0400 [thread overview]
Message-ID: <4EF45309.7060005@parallels.com> (raw)
In-Reply-To: <1323682263-1310-1-git-send-email-glommer@parallels.com>
On 12/12/2011 01:31 PM, Glauber Costa wrote:
> In commit a25cac5198 we changed the way we calculate idle and iowait
> for /proc/stat displaying purposes. However, this same information
> is also displayed in /proc/uptime. These values can now be inconsistent.
>
> So I propose we draw both idle values from the same place. In theory,
> we only need to do it for get_idle_time(). get_iowait_time() is moved
> as well for consistency only.
>
> I moved the functions to sched/core.c so it can live among its other
> friends like nr_iowait(), etc.
>
You guys have any opinions on this ?
I see that Michal got another fix for this in stat.c already, so I'd
have to respin this one anyway. Just let me know if this is wanted
Thanks
next parent reply other threads:[~2011-12-23 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1323682263-1310-1-git-send-email-glommer@parallels.com>
2011-12-23 10:08 ` Glauber Costa [this message]
2011-12-23 13:39 ` [PATCH] move get_idle_time , get_iowait_time to sched/core.c Michal Hocko
2011-12-23 13:40 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF45309.7060005@parallels.com \
--to=glommer@parallels.com \
--cc=a.p.zijlstra@chello.nl \
--cc=adobriyan@gmail.com \
--cc=arnd@arndb.de \
--cc=davej@redhat.com \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox