public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "Jörg Sommer" <joerg@alea.gnuu.de>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"kvm list" <kvm@vger.kernel.org>,
	kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Current kernel fails to compile with KVM on PowerPC
Date: Sun, 25 Dec 2011 11:38:27 +0200	[thread overview]
Message-ID: <4EF6EF13.7080304@redhat.com> (raw)
In-Reply-To: <C40CA3A1-2397-423B-96B3-CBEE4EA7EA30@suse.de>

On 12/24/2011 07:05 PM, Alexander Graf wrote:
> I was actually thinking of:
>
> commit dfc209648daf8ba4197e71376b76c95fd26fd272
> Author: Andreas Schwab <schwab@linux-m68k.org>
> Date:   Tue Nov 8 07:17:39 2011 +0000
>
>     KVM: PPC: protect use of kvmppc_h_pr
>     
>     kvmppc_h_pr is only available if CONFIG_KVM_BOOK3S_64_PR.
>     
>     Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
>     Signed-off-by: Alexander Graf <agraf@suse.de>
>
> diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c
> index 72559b0..aaefe19 100644
> --- a/arch/powerpc/kvm/book3s_pr.c
> +++ b/arch/powerpc/kvm/book3s_pr.c
> @@ -660,10 +660,12 @@ program_interrupt:
>                         ulong cmd = kvmppc_get_gpr(vcpu, 3);
>                         int i;
>  
> +#ifdef CONFIG_KVM_BOOK3S_64_PR
>                         if (kvmppc_h_pr(vcpu, cmd) == EMULATE_DONE) {
>                                 r = RESUME_GUEST;
>                                 break;
>                         }
> +#endif
>  
>                         run->papr_hcall.nr = cmd;
>                         for (i = 0; i < 9; ++i) {
>
> But yes :). I guess we need to make sure this commit also lands in 3.2 :(.
>
>

Please post it ASAP, I'm preparing a pull request for 3.2.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2011-12-25  9:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 19:48 Current kernel fails to compile with KVM on PowerPC Jörg Sommer
2011-11-07 20:16 ` Avi Kivity
2011-11-07 20:43   ` Alexander Graf
2011-11-22 20:04 ` Jörg Sommer
2011-11-22 21:29   ` Alexander Graf
2011-12-11 15:16     ` Jörg Sommer
2011-12-12  7:26       ` Alexander Graf
2012-02-20 17:38     ` Jörg Sommer
2012-02-20 21:27       ` Alexander Graf
2012-02-21  8:32         ` Jörg Sommer
2012-02-25 14:51           ` Jörg Sommer
2012-02-26  0:06             ` Jörg Sommer
2012-02-26 23:54               ` Alexander Graf
2012-02-26 11:43             ` Alexander Graf
2012-02-27  0:08               ` Jörg Sommer
2012-02-27  0:30                 ` Alexander Graf
2012-02-27 11:31                   ` Jörg Sommer
2011-12-20 20:27 ` Jörg Sommer
2011-12-23 13:50   ` Alexander Graf
2011-12-24 10:31     ` Jörg Sommer
2011-12-24 11:13       ` Jörg Sommer
2011-12-24 17:05         ` Alexander Graf
2011-12-25  9:38           ` Avi Kivity [this message]
2011-12-25 11:01           ` Jörg Sommer
2011-12-26 14:18             ` Alexander Graf
2011-12-24 10:59     ` Jörg Sommer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF6EF13.7080304@redhat.com \
    --to=avi@redhat.com \
    --cc=agraf@suse.de \
    --cc=joerg@alea.gnuu.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox