From: Axel Theilmann <theilmann@pre-sense.de>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux-scsi@vger.kernel.org, Huajun Li <huajun.li.lee@gmail.com>,
jbottomley@parallels.com, linux-kernel@vger.kernel.org
Subject: Re: Yet another hot unplug NULL pointer dereference (was Re: status of oops in sd_revalidate_disk?)
Date: Tue, 27 Dec 2011 11:21:48 +0100 [thread overview]
Message-ID: <4EF99C3C.8030602@pre-sense.de> (raw)
In-Reply-To: <20111225215804.03ef9402@stein>
On 12/25/2011 09:58 PM, Stefan Richter wrote:
moin,
> as far as I remember, all Linux releases in 2011 have been broken WRT hot
> removal of block devices; some more severely, some less. Various patches
> for this went in over the year, but if they fixed anything, they always
> uncovered the next lingering unplug related bug. The presumed first Linux
so now there are 2 known NULL-pointer problems in the cd-rom code and one in
the scsi-disk code.
Would a complete fix for this issue be a question of locating all the
possible NULL-pointers and fixing them or do you think that the hotplug
problem has to be fixed on a more "fundamental" level?
Even if there is a more fundamental problem below that has to be fixed, it
would still be nice to get in fixes for the dereferences that are currently
known to keep peoples systems from crashing.
We built a kernel with Huajun's patch included and will do some tests to see
if the problem goes away (and no others show up).
> With a little bit of bad luck, udisks-daemon or in older distros hald
> should hit the bug too. Under kernel 3.1 I typically just got processes
> hanging in unkillable sleep. With kernel 3.2-rc7 I get an instant kernel
> panic.
Yes, udisks is what probably triggers the bug for us. People removing USB
media before udisks is finished initializing the medium. With kernel 3.1.4
we get instant kernel panics as well.
tty, axel
--
Dipl.-Inform. Axel Theilmann theilmann@pre-sense.de
Tel. (+49) 040 / 244 2407 - 13
Fax (+49) 040 / 244 2407 - 24
Mobil (+49) 0151 / 116 18 664
PRESENSE Technologies GmbH Sachsenstr. 5, 20097 Hamburg
USt-IdNr.: DE263765024
Geschäftsführer/Managing Directors AG Hamburg, HRB 107844
Till Dörges Jürgen Sander Axel Theilmann
next prev parent reply other threads:[~2011-12-27 10:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4EE8E419.8010000@pre-sense.de>
[not found] ` <CA+v9cxZFUC45WD0=+8mvH2Tq_xvX3PgaW4ttzPep0jqvqab_6w@mail.gmail.com>
2011-12-25 20:58 ` Yet another hot unplug NULL pointer dereference (was Re: status of oops in sd_revalidate_disk?) Stefan Richter
2011-12-27 10:21 ` Axel Theilmann [this message]
2011-12-27 13:40 ` Stefan Richter
2012-02-14 11:34 ` Jun'ichi Nomura
2012-02-14 11:54 ` Bart Van Assche
2012-02-14 13:38 ` Stefan Richter
2012-02-14 19:11 ` Bart Van Assche
2012-02-15 2:26 ` Jun'ichi Nomura
2012-02-15 11:29 ` Bart Van Assche
2012-02-16 1:04 ` Jun'ichi Nomura
2012-03-13 18:10 ` Bart Van Assche
2012-03-16 8:58 ` Jun'ichi Nomura
2012-03-16 18:53 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF99C3C.8030602@pre-sense.de \
--to=theilmann@pre-sense.de \
--cc=huajun.li.lee@gmail.com \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox