public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [bluetooth] linux-3.x regression (bisected)
@ 2011-12-22 23:18 Rene Herman
  2011-12-27 17:22 ` Andre Guedes
  0 siblings, 1 reply; 22+ messages in thread
From: Rene Herman @ 2011-12-22 23:18 UTC (permalink / raw)
  To: Andre Guedes, Gustavo F. Padovan; +Cc: linux-kernel

Good day.

A while ago, my noname USB Bluetooth adapter stopped working, with from 
that point on only "Bluetooth: hci0 command tx timeout" appearing in the 
kernel messages.

I just now got around to looking at it and bisected this to commit 
eead27da60df80a112d1ac3ea482226e9794c26b:

===
Author: Andre Guedes <andre.guedes@openbossa.org>
Date:   Thu Jun 30 19:20:55 2011 -0300

     Bluetooth: Add lmp_host_le_capable() macro

     Since we have the extended LMP features properly implemented, we
     should check the LMP_HOST_LE bit to know if the host supports LE.

     Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
     Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
===

while that commit cannot be reverted outright due to dependencies, 
reverting it functionally fixes things for me. That is, Bluetooth works 
again after applying (to linux-3.1.6):

===
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 56943ad..c7f794e 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -540,7 +540,7 @@ int hci_dev_open(__u16 dev)
                 ret = __hci_request(hdev, hci_init_req, 0,
 
msecs_to_jiffies(HCI_INIT_TIMEOUT));

-               if (lmp_host_le_capable(hdev))
+               if (lmp_le_capable(hdev))
                         ret = __hci_request(hdev, hci_le_init_req, 0,
 
msecs_to_jiffies(HCI_INIT_TIMEOUT));
===

It seems that my adapter wasn't ready for the change. It is a:

002 Device 002: ID 1131:1004 Integrated System Solution Corp. Bluetooth 
Device

If more specific information is wanted (to add adapter-specific quirk 
handling, perhaps?) please be verbose on how to obtain it. I don't know 
anything about Bluetooth

Rene.

^ permalink raw reply related	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2012-01-04 15:12 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-22 23:18 [bluetooth] linux-3.x regression (bisected) Rene Herman
2011-12-27 17:22 ` Andre Guedes
2011-12-27 19:38   ` Rene Herman
2011-12-27 20:30     ` Gustavo Padovan
2011-12-27 22:19       ` Rene Herman
2011-12-28  1:22         ` Gustavo Padovan
2011-12-28  1:28           ` Gustavo Padovan
2011-12-28  1:53             ` Rene Herman
2011-12-28  1:57               ` Rene Herman
2011-12-28 15:52               ` Gustavo Padovan
2011-12-28 16:04                 ` David Herrmann
2011-12-28 16:16                   ` Gustavo Padovan
2011-12-28 16:48                 ` Marcel Holtmann
2011-12-28 17:24                   ` Rene Herman
2011-12-28 22:17                   ` Rene Herman
2011-12-28 23:07                     ` Marcel Holtmann
2011-12-29  0:22                       ` Rene Herman
2012-01-04 12:04                   ` Rene Herman
2012-01-04 14:16                     ` Andre Guedes
2012-01-04 15:12                       ` Rene Herman
2011-12-28 16:54                 ` Rene Herman
2011-12-28 17:12                   ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox