From: Ryan Mallon <rmallon@gmail.com>
To: Ravishankar karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, dan.carpenter@oracle.com,
joe@perches.com, valdis.kletnieks@vt.edu, jj@chaosbits.net
Subject: Re: [PATCH 6/6] Staging: comedi: fix initialise statics to 0 or NULL issue in ni_mio_cs.c.
Date: Tue, 03 Jan 2012 07:45:56 +1100 [thread overview]
Message-ID: <4F021784.7070802@gmail.com> (raw)
In-Reply-To: <1325510273-20091-1-git-send-email-ravishankar.km@greenturtles.in>
On 03/01/12 00:17, Ravishankar karkala Mallikarjunayya wrote:
> This is a patch to the ni_mio_cs.c file that fixes up a initialise
> statics to 0 or NULL warning found by the checkpatch.pl tool.
>
> Breaks the build.
Greg was pointing out that your previous patch broke the build. He did
not literally mean that you should add the above message to the commit
log. The fact that you did, seemingly thinking that doing so was
correct, is just ... scary.
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
> ---
> drivers/staging/comedi/drivers/ni_mio_cs.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_mio_cs.c b/drivers/staging/comedi/drivers/ni_mio_cs.c
> index 53ec24b..cb3d08b 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_cs.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_cs.c
> @@ -258,7 +258,7 @@ static void mio_cs_config(struct pcmcia_device *link);
> static void cs_release(struct pcmcia_device *link);
> static void cs_detach(struct pcmcia_device *);
>
> -static struct pcmcia_device *cur_dev = NULL;
> +static struct pcmcia_device *cur_dev;
>
> static int cs_attach(struct pcmcia_device *link)
> {
> @@ -351,6 +351,8 @@ static int mio_cs_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> printk("comedi%d: %s: DAQCard: io 0x%04lx, irq %u, ",
> dev->minor, dev->driver->driver_name, dev->iobase, irq);
>
> +
> +
Why this change?
> #if 0
> {
> int i;
> @@ -400,7 +402,7 @@ static int mio_cs_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> }
>
> static int ni_getboardtype(struct comedi_device *dev,
> - struct pcmcia_device *link)
> + struct pcmcia_device *link)
Why this change?
> {
> int i;
>
next prev parent reply other threads:[~2012-01-02 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 13:17 [PATCH 6/6] Staging: comedi: fix initialise statics to 0 or NULL issue in ni_mio_cs.c Ravishankar karkala Mallikarjunayya
2012-01-02 20:45 ` Ryan Mallon [this message]
2012-01-03 0:19 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F021784.7070802@gmail.com \
--to=rmallon@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jj@chaosbits.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankar.km@greenturtles.in \
--cc=valdis.kletnieks@vt.edu \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox