[PATCH 6/6] Staging: comedi: fix initialise statics to 0 or NULL issue in ni_mio_cs.c.

[PATCH 6/6] Staging: comedi: fix initialise statics to 0 or NULL issue in ni_mio_cs.c.

[Ravishankar karkala Mallikarjunayya]

This is a patch to the ni_mio_cs.c file that fixes up a initialise
statics to 0 or NULL warning found by the checkpatch.pl tool.

Breaks the build.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
---
 drivers/staging/comedi/drivers/ni_mio_cs.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_mio_cs.c b/drivers/staging/comedi/drivers/ni_mio_cs.c
index 53ec24b..cb3d08b 100644
--- a/drivers/staging/comedi/drivers/ni_mio_cs.c
+++ b/drivers/staging/comedi/drivers/ni_mio_cs.c
@@ -258,7 +258,7 @@ static void mio_cs_config(struct pcmcia_device *link);
 static void cs_release(struct pcmcia_device *link);
 static void cs_detach(struct pcmcia_device *);
 
-static struct pcmcia_device *cur_dev = NULL;
+static struct pcmcia_device *cur_dev;
 
 static int cs_attach(struct pcmcia_device *link)
 {
@@ -351,6 +351,8 @@ static int mio_cs_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 	printk("comedi%d: %s: DAQCard: io 0x%04lx, irq %u, ",
 	       dev->minor, dev->driver->driver_name, dev->iobase, irq);
 
+
+
 #if 0
 	{
 		int i;
@@ -400,7 +402,7 @@ static int mio_cs_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 }
 
 static int ni_getboardtype(struct comedi_device *dev,
-			   struct pcmcia_device *link)
+		struct pcmcia_device *link)
 {
 	int i;
 
-- 
1.7.0.4

Re: [PATCH 6/6] Staging: comedi: fix initialise statics to 0 or NULL issue in ni_mio_cs.c.

[Ryan Mallon]

On 03/01/12 00:17, Ravishankar karkala Mallikarjunayya wrote:
> This is a patch to the ni_mio_cs.c file that fixes up a initialise
> statics to 0 or NULL warning found by the checkpatch.pl tool.
>
> Breaks the build.

Greg was pointing out that your previous patch broke the build. He did
not literally mean that you should add the above message to the commit
log. The fact that you did, seemingly thinking that doing so was
correct, is just ... scary.

> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
> ---
>  drivers/staging/comedi/drivers/ni_mio_cs.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_mio_cs.c b/drivers/staging/comedi/drivers/ni_mio_cs.c
> index 53ec24b..cb3d08b 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_cs.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_cs.c
> @@ -258,7 +258,7 @@ static void mio_cs_config(struct pcmcia_device *link);
>  static void cs_release(struct pcmcia_device *link);
>  static void cs_detach(struct pcmcia_device *);
>  
> -static struct pcmcia_device *cur_dev = NULL;
> +static struct pcmcia_device *cur_dev;
>  
>  static int cs_attach(struct pcmcia_device *link)
>  {
> @@ -351,6 +351,8 @@ static int mio_cs_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  	printk("comedi%d: %s: DAQCard: io 0x%04lx, irq %u, ",
>  	       dev->minor, dev->driver->driver_name, dev->iobase, irq);
>  
> +
> +

Why this change?

>  #if 0
>  	{
>  		int i;
> @@ -400,7 +402,7 @@ static int mio_cs_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  }
>  
>  static int ni_getboardtype(struct comedi_device *dev,
> -			   struct pcmcia_device *link)
> +		struct pcmcia_device *link)

Why this change?

>  {
>  	int i;
>  

RE: [PATCH 6/6] Staging: comedi: fix initialise statics to 0 or NULL issue in ni_mio_cs.c.

[KY Srinivasan]

> -----Original Message-----
> From: devel-bounces@linuxdriverproject.org [mailto:devel-
> bounces@linuxdriverproject.org] On Behalf Of Ravishankar karkala
> Mallikarjunayya
> Sent: Monday, January 02, 2012 8:18 AM
> To: gregkh@suse.de; wfp5p@virginia.edu
> Cc: devel@driverdev.osuosl.org; valdis.kletnieks@vt.edu; rmallon@gmail.com;
> linux-kernel@vger.kernel.org; jj@chaosbits.net; joe@perches.com;
> dan.carpenter@oracle.com; Ravishankar karkala Mallikarjunayya
> Subject: [PATCH 6/6] Staging: comedi: fix initialise statics to 0 or NULL issue in
> ni_mio_cs.c.
> 
> This is a patch to the ni_mio_cs.c file that fixes up a initialise
> statics to 0 or NULL warning found by the checkpatch.pl tool.
> 
> Breaks the build.

Why would you submit a patch that breaks the build?

K. Y