From: Ryan Mallon <rmallon@gmail.com>
To: Ravishankar karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, dan.carpenter@oracle.com,
joe@perches.com, valdis.kletnieks@vt.edu, jj@chaosbits.net
Subject: Re: [PATCH 5/6] Staging: comedi: fix line over 80 character issue in daqboard2000.c
Date: Tue, 03 Jan 2012 07:47:18 +1100 [thread overview]
Message-ID: <4F0217D6.2070705@gmail.com> (raw)
In-Reply-To: <1325509801-20036-5-git-send-email-ravishankar.km@greenturtles.in>
On 03/01/12 00:10, Ravishankar karkala Mallikarjunayya wrote:
> This is a patch to the daqboard2000.c file that fixes up a
> line over 80 character warning found by the checkpatch.pl tool.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
> ---
> drivers/staging/comedi/drivers/daqboard2000.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
> index e61c6a8..3550c6a 100644
> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -414,7 +414,7 @@ static int daqboard2000_ai_insn_read(struct comedi_device *dev,
>
> /* If pacer clock is not set to some high value (> 10 us), we
> risk multiple samples to be put into the result FIFO. */
> - fpga->acqPacerClockDivLow = 1000000; /* 1 second, should be long enough */
> + /* 1 second, should be long enough */
You broke the driver here.
> fpga->acqPacerClockDivHigh = 0;
>
> gain = CR_RANGE(insn->chanspec);
> @@ -526,7 +526,8 @@ static void daqboard2000_pulseProgPin(struct comedi_device *dev)
> writel(DAQBOARD2000_SECRProgPinHi, devpriv->plx + 0x6c);
> udelay(10000);
> writel(DAQBOARD2000_SECRProgPinLo, devpriv->plx + 0x6c);
> - udelay(10000); /* Not in the original code, but I like symmetry... */
> + /* Not in the original code, but I like symmetry... */
> + udelay(10000);
> }
>
> static int daqboard2000_pollCPLD(struct comedi_device *dev, int mask)
prev parent reply other threads:[~2012-01-02 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 13:09 [PATCH 1/6] Staging: comedi: fix printk warning issue in ni_at_a2150.c Ravishankar karkala Mallikarjunayya
2012-01-02 13:09 ` [PATCH 2/6] Staging: comedi: fix printk warning issue in dt2801.c Ravishankar karkala Mallikarjunayya
2012-01-02 13:09 ` [PATCH 3/6] Staging: comedi: fix printk warning issue in contec_pci_dio.c Ravishankar karkala Mallikarjunayya
2012-01-02 13:10 ` [PATCH 4/6] Staging: comedi: fix printk warning issue in amplc_pci230.c Ravishankar karkala Mallikarjunayya
2012-01-02 13:10 ` [PATCH 5/6] Staging: comedi: fix line over 80 character issue in daqboard2000.c Ravishankar karkala Mallikarjunayya
2012-01-02 20:47 ` Ryan Mallon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0217D6.2070705@gmail.com \
--to=rmallon@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jj@chaosbits.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankar.km@greenturtles.in \
--cc=valdis.kletnieks@vt.edu \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).