From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754895Ab2ADME1 (ORCPT ); Wed, 4 Jan 2012 07:04:27 -0500 Received: from smtpq3.gn.mail.iss.as9143.net ([212.54.34.166]:37072 "EHLO smtpq3.gn.mail.iss.as9143.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754063Ab2ADMEZ (ORCPT ); Wed, 4 Jan 2012 07:04:25 -0500 Message-ID: <4F044042.2080502@gmail.com> Date: Wed, 04 Jan 2012 13:04:18 +0100 From: Rene Herman User-Agent: Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20111224 Thunderbird/9.0.1 MIME-Version: 1.0 To: Marcel Holtmann CC: Gustavo Padovan , Andre Guedes , linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org Subject: Re: [bluetooth] linux-3.x regression (bisected) References: <4EF3BACA.1080405@gmail.com> <4EFA1EB8.9090005@gmail.com> <20111227203008.GA13870@joana> <4EFA447C.3030906@gmail.com> <20111228012248.GC13870@joana> <20111228012850.GD13870@joana> <4EFA7696.6060506@gmail.com> <20111228155225.GA23292@joana> <1325090923.1965.282.camel@aeonflux> In-Reply-To: <1325090923.1965.282.camel@aeonflux> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Ziggo-spambar: --- X-Ziggo-spamscore: -3.6 X-Ziggo-spamreport: ALL_TRUSTED=-1,BAYES_00=-1.9,FREEMAIL_FROM=0.5,PROLO_TRUST_RDNS=-3,RDNS_DYNAMIC=0.982,SPF_NEUTRAL=0.779 X-Ziggo-Spam-Status: No X-Spam-Flag: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28-12-11 17:48, Marcel Holtmann wrote: > The correct patch would be something like this: > > diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c > index 919e3c0..b6eb9c5 100644 > --- a/net/bluetooth/hci_event.c > +++ b/net/bluetooth/hci_event.c > @@ -711,7 +711,8 @@ static void hci_cc_read_local_ext_features(struct hci_dev *h > if (rp->status) > return; > > - memcpy(hdev->extfeatures, rp->features, 8); > + if (rp->page == 1) > + memcpy(hdev->extfeatures, rp->features, 8); > > hci_req_complete(hdev, HCI_OP_READ_LOCAL_EXT_FEATURES, rp->status); > } > > The current patch is actually fully broken anyway. So besides switching > LE on when requesting page 0, you will also switch it off when > requesting any other page and it accidentally returns 0x00 since we > unconditionally overwrite it. Any word on a final fix for this? Regards, Rene Herman