From: Jiang Liu <liuj97@gmail.com>
To: Hien Nguyen <hien@us.ibm.com>, Jim Keniston <jkenisto@us.ibm.com>,
Prasanna S Panchamukhi <prasanna@in.ibm.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] kprobe: fix a memory leak in function pre_handler_kretprobe()
Date: Sat, 07 Jan 2012 00:49:30 +0800 [thread overview]
Message-ID: <4F07261A.6080403@gmail.com> (raw)
From: Jiang Liu<liuj97@gmail.com>
In function pre_handler_kretprobe(), the allocated kretprobe_instance object will
be leaked if the entry_handler callback returns non-zero. This may cause all the
preallocated kretprobe_instance objects exhausted. This issue could be reproduced
by changing samples/kprobes/kretprobe_example.c to probe "mutex_unlock". And the
fix is straight forward, just put the allocated kretprobe_instance object back
onto the free_instances list.
Signed-off-by: Jiang Liu<liuj97@gmail.com>
Cc: Hien Nguyen<hien@us.ibm.com>
Cc: Jim Keniston<jkenisto@us.ibm.com>
Cc: Prasanna S Panchamukhi<prasanna@in.ibm.com>
---
kprobes.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -1660,8 +1660,12 @@
ri->rp = rp;
ri->task = current;
- if (rp->entry_handler&& rp->entry_handler(ri, regs))
+ if (rp->entry_handler&& rp->entry_handler(ri, regs)) {
+ spin_lock_irqsave(&rp->lock, flags);
+ hlist_add_head(&ri->hlist,&rp->free_instances);
+ spin_unlock_irqrestore(&rp->lock, flags);
return 0;
+ }
arch_prepare_kretprobe(ri, regs);
next reply other threads:[~2012-01-06 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 16:49 Jiang Liu [this message]
2012-01-06 17:56 ` [PATCH] kprobe: fix a memory leak in function pre_handler_kretprobe() Jim Keniston
2012-01-09 5:18 ` Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F07261A.6080403@gmail.com \
--to=liuj97@gmail.com \
--cc=hien@us.ibm.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox