From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Jim Keniston <jkenisto@linux.vnet.ibm.com>
Cc: ananth@in.ibm.com, lkml <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH][RESEND] kprobes: initialize before using a hlist
Date: Tue, 10 Jan 2012 11:46:19 +0900 [thread overview]
Message-ID: <4F0BA67B.8070100@hitachi.com> (raw)
In-Reply-To: <1326156463.3609.1.camel@localhost>
(2012/01/10 9:47), Jim Keniston wrote:
> On Mon, 2012-01-09 at 13:50 +0530, Ananth N Mavinakayanahalli wrote:
>> From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>>
>> Commit ef53d9c5e introduced a bug where we can potentially leak
>> kretprobe_instances since we initialize a hlist head after having
>> used it.
>>
>> Initialize the hlist head before using it.
>>
>> (Resent with correct email ID for -stable)
>>
>> Reported by: Jim Keniston <jkenisto@us.ibm.com>
>> Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>> Cc: <stable@vger.kernel.org>
>
> Acked-by: Jim Keniston <jkenisto@us.ibm.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thank you!
>
>> ---
>> kernel/kprobes.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: linux-3.2/kernel/kprobes.c
>> ===================================================================
>> --- linux-3.2.orig/kernel/kprobes.c
>> +++ linux-3.2/kernel/kprobes.c
>> @@ -1077,6 +1077,7 @@ void __kprobes kprobe_flush_task(struct
>> /* Early boot. kretprobe_table_locks not yet initialized. */
>> return;
>>
>> + INIT_HLIST_HEAD(&empty_rp);
>> hash = hash_ptr(tk, KPROBE_HASH_BITS);
>> head = &kretprobe_inst_table[hash];
>> kretprobe_table_lock(hash, &flags);
>> @@ -1085,7 +1086,6 @@ void __kprobes kprobe_flush_task(struct
>> recycle_rp_inst(ri, &empty_rp);
>> }
>> kretprobe_table_unlock(hash, &flags);
>> - INIT_HLIST_HEAD(&empty_rp);
>> hlist_for_each_entry_safe(ri, node, tmp, &empty_rp, hlist) {
>> hlist_del(&ri->hlist);
>> kfree(ri);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
prev parent reply other threads:[~2012-01-10 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 8:20 [PATCH][RESEND] kprobes: initialize before using a hlist Ananth N Mavinakayanahalli
2012-01-10 0:47 ` Jim Keniston
2012-01-10 2:46 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0BA67B.8070100@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=ananth@in.ibm.com \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).