* [PATCH] dmaengine/dw_dmac: Hibernation support in dw_dmac
@ 2012-01-11 6:23 Rajeev Kumar
2012-01-11 6:25 ` deepaksi
0 siblings, 1 reply; 4+ messages in thread
From: Rajeev Kumar @ 2012-01-11 6:23 UTC (permalink / raw)
To: viresh.kumar
Cc: linus.walleij, mirko.gardi, bhupesh.sharma, deepak.sikri,
shiraz.hashim, vipin.kumar, vipulkumar.samar, pratyush.anand,
rajeev-dlh.kumar, armando.visconti, vinod.koul, dan.j.williams,
linux-kernel, linux-arm-kernel, linux
The suspend and resume implementation is through dev_pm_ops in dmac. So
in order to support hibernation, freeze, thaw and restore features are required.
Signed-off-by: Rajeev Kumar <rajeev-dlh.kumar@st.com>
---
drivers/dma/dw_dmac.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index d2e1c25..cb346d6 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -1568,6 +1568,9 @@ static int dw_resume_noirq(struct device *dev)
static const struct dev_pm_ops dw_dev_pm_ops = {
.suspend_noirq = dw_suspend_noirq,
.resume_noirq = dw_resume_noirq,
+ .freeze_noirq = dw_suspend_noirq,
+ .thaw_noirq = dw_resume_noirq,
+ .restore_noirq = dw_resume_noirq,
};
static struct platform_driver dw_driver = {
--
1.6.0.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dmaengine/dw_dmac: Hibernation support in dw_dmac
2012-01-11 6:23 [PATCH] dmaengine/dw_dmac: Hibernation support in dw_dmac Rajeev Kumar
@ 2012-01-11 6:25 ` deepaksi
2012-01-11 6:50 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: deepaksi @ 2012-01-11 6:25 UTC (permalink / raw)
To: Rajeev KUMAR
Cc: Viresh KUMAR, linus.walleij@linaro.org, Mirko GARDI,
Bhupesh SHARMA, Shiraz HASHIM, Vipin KUMAR, Vipul Kumar SAMAR,
Pratyush ANAND, Armando VISCONTI, vinod.koul@intel.com,
dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk
On 1/11/2012 11:53 AM, Rajeev KUMAR wrote:
> The suspend and resume implementation is through dev_pm_ops in dmac. So
> in order to support hibernation, freeze, thaw and restore features are required.
>
> Signed-off-by: Rajeev Kumar <rajeev-dlh.kumar@st.com>
> ---
> drivers/dma/dw_dmac.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index d2e1c25..cb346d6 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -1568,6 +1568,9 @@ static int dw_resume_noirq(struct device *dev)
> static const struct dev_pm_ops dw_dev_pm_ops = {
> .suspend_noirq = dw_suspend_noirq,
> .resume_noirq = dw_resume_noirq,
> + .freeze_noirq = dw_suspend_noirq,
> + .thaw_noirq = dw_resume_noirq,
> + .restore_noirq = dw_resume_noirq,
> };
>
>
Spacing and tab issue ..Please check at
thaw_noirq
> static struct platform_driver dw_driver = {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dmaengine/dw_dmac: Hibernation support in dw_dmac
2012-01-11 6:25 ` deepaksi
@ 2012-01-11 6:50 ` Viresh Kumar
2012-01-11 6:55 ` Rajeev kumar
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2012-01-11 6:50 UTC (permalink / raw)
To: Deepak SIKRI
Cc: Rajeev KUMAR, linus.walleij@linaro.org, Mirko GARDI,
Bhupesh SHARMA, Shiraz HASHIM, Vipin KUMAR, Vipul Kumar SAMAR,
Pratyush ANAND, Armando VISCONTI, vinod.koul@intel.com,
dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk
On 1/11/2012 11:55 AM, Deepak SIKRI wrote:
>> + .freeze_noirq = dw_suspend_noirq,
>> + .thaw_noirq = dw_resume_noirq,
>> + .restore_noirq = dw_resume_noirq,
You need to add poweroff_noirq too.
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine/dw_dmac: Hibernation support in dw_dmac
2012-01-11 6:50 ` Viresh Kumar
@ 2012-01-11 6:55 ` Rajeev kumar
0 siblings, 0 replies; 4+ messages in thread
From: Rajeev kumar @ 2012-01-11 6:55 UTC (permalink / raw)
To: Viresh KUMAR
Cc: Deepak SIKRI, linus.walleij@linaro.org, Mirko GARDI,
Bhupesh SHARMA, Shiraz HASHIM, Vipin KUMAR, Vipul Kumar SAMAR,
Pratyush ANAND, Armando VISCONTI, vinod.koul@intel.com,
dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk
On 1/11/2012 12:20 PM, Viresh KUMAR wrote:
> On 1/11/2012 11:55 AM, Deepak SIKRI wrote:
>>> + .freeze_noirq = dw_suspend_noirq,
>>> + .thaw_noirq = dw_resume_noirq,
>>> + .restore_noirq = dw_resume_noirq,
>
> You need to add poweroff_noirq too.
>
Yep, will add this in V2
Best Regards
Rajeev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-11 6:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-11 6:23 [PATCH] dmaengine/dw_dmac: Hibernation support in dw_dmac Rajeev Kumar
2012-01-11 6:25 ` deepaksi
2012-01-11 6:50 ` Viresh Kumar
2012-01-11 6:55 ` Rajeev kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox