* [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver
@ 2012-01-12 8:26 Michal Simek
2012-01-12 15:56 ` Alan Stern
0 siblings, 1 reply; 4+ messages in thread
From: Michal Simek @ 2012-01-12 8:26 UTC (permalink / raw)
To: linux-kernel
Cc: Michal Simek, Alan Stern, Greg Kroah-Hartman, Grant Likely,
linux-usb, devicetree-discuss
Drivers shouldn't use NO_IRQ. This driver is used
by Microblaze and PPC. PPC defines NO_IRQ as 0
and Microblaze has removed it.
Signed-off-by: Michal Simek <monstr@monstr.eu>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Greg Kroah-Hartman <gregkh@suse.de>
CC: Grant Likely <grant.likely@secretlab.ca>
CC: linux-usb@vger.kernel.org
CC: devicetree-discuss@lists.ozlabs.org
---
drivers/usb/host/ehci-xilinx-of.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
index 32793ce..9c2cc46 100644
--- a/drivers/usb/host/ehci-xilinx-of.c
+++ b/drivers/usb/host/ehci-xilinx-of.c
@@ -183,7 +183,7 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op)
}
irq = irq_of_parse_and_map(dn, 0);
- if (irq == NO_IRQ) {
+ if (!irq) {
printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__);
rv = -EBUSY;
goto err_irq;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver
2012-01-12 8:26 [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver Michal Simek
@ 2012-01-12 15:56 ` Alan Stern
2012-01-13 11:27 ` Michal Simek
0 siblings, 1 reply; 4+ messages in thread
From: Alan Stern @ 2012-01-12 15:56 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, Greg Kroah-Hartman, Grant Likely, linux-usb,
devicetree-discuss
On Thu, 12 Jan 2012, Michal Simek wrote:
> Drivers shouldn't use NO_IRQ. This driver is used
> by Microblaze and PPC. PPC defines NO_IRQ as 0
> and Microblaze has removed it.
>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
> CC: Alan Stern <stern@rowland.harvard.edu>
> CC: Greg Kroah-Hartman <gregkh@suse.de>
> CC: Grant Likely <grant.likely@secretlab.ca>
> CC: linux-usb@vger.kernel.org
> CC: devicetree-discuss@lists.ozlabs.org
> ---
> drivers/usb/host/ehci-xilinx-of.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> index 32793ce..9c2cc46 100644
> --- a/drivers/usb/host/ehci-xilinx-of.c
> +++ b/drivers/usb/host/ehci-xilinx-of.c
> @@ -183,7 +183,7 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op)
> }
>
> irq = irq_of_parse_and_map(dn, 0);
> - if (irq == NO_IRQ) {
> + if (!irq) {
> printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__);
> rv = -EBUSY;
> goto err_irq;
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver
2012-01-12 15:56 ` Alan Stern
@ 2012-01-13 11:27 ` Michal Simek
2012-01-13 18:39 ` Grant Likely
0 siblings, 1 reply; 4+ messages in thread
From: Michal Simek @ 2012-01-13 11:27 UTC (permalink / raw)
To: Grant Likely
Cc: Alan Stern, Michal Simek, linux-kernel, Greg Kroah-Hartman,
linux-usb, devicetree-discuss
Alan Stern wrote:
> On Thu, 12 Jan 2012, Michal Simek wrote:
>
>> Drivers shouldn't use NO_IRQ. This driver is used
>> by Microblaze and PPC. PPC defines NO_IRQ as 0
>> and Microblaze has removed it.
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>> CC: Alan Stern <stern@rowland.harvard.edu>
>> CC: Greg Kroah-Hartman <gregkh@suse.de>
>> CC: Grant Likely <grant.likely@secretlab.ca>
>> CC: linux-usb@vger.kernel.org
>> CC: devicetree-discuss@lists.ozlabs.org
>> ---
>> drivers/usb/host/ehci-xilinx-of.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
>> index 32793ce..9c2cc46 100644
>> --- a/drivers/usb/host/ehci-xilinx-of.c
>> +++ b/drivers/usb/host/ehci-xilinx-of.c
>> @@ -183,7 +183,7 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op)
>> }
>>
>> irq = irq_of_parse_and_map(dn, 0);
>> - if (irq == NO_IRQ) {
>> + if (!irq) {
>> printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__);
>> rv = -EBUSY;
>> goto err_irq;
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
Thanks Alan.
I have seen that Grant sent the same patch to lkml too.
Here is the thread: http://lkml.org/lkml/2012/1/11/342
Grant: How fast do you think you are able to merge your patches?
Currently I have remove NO_IRQ from Microblaze and we use this driver which
means that driver compilation failed right now. That's why I would like to fix asap.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver
2012-01-13 11:27 ` Michal Simek
@ 2012-01-13 18:39 ` Grant Likely
0 siblings, 0 replies; 4+ messages in thread
From: Grant Likely @ 2012-01-13 18:39 UTC (permalink / raw)
To: Michal Simek
Cc: Alan Stern, Michal Simek, linux-kernel, Greg Kroah-Hartman,
linux-usb, devicetree-discuss
On Fri, Jan 13, 2012 at 12:27:22PM +0100, Michal Simek wrote:
> Alan Stern wrote:
> >On Thu, 12 Jan 2012, Michal Simek wrote:
> >
> >>Drivers shouldn't use NO_IRQ. This driver is used
> >>by Microblaze and PPC. PPC defines NO_IRQ as 0
> >>and Microblaze has removed it.
> >>
> >>Signed-off-by: Michal Simek <monstr@monstr.eu>
> >>CC: Alan Stern <stern@rowland.harvard.edu>
> >>CC: Greg Kroah-Hartman <gregkh@suse.de>
> >>CC: Grant Likely <grant.likely@secretlab.ca>
> >>CC: linux-usb@vger.kernel.org
> >>CC: devicetree-discuss@lists.ozlabs.org
> >>---
> >> drivers/usb/host/ehci-xilinx-of.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >>diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> >>index 32793ce..9c2cc46 100644
> >>--- a/drivers/usb/host/ehci-xilinx-of.c
> >>+++ b/drivers/usb/host/ehci-xilinx-of.c
> >>@@ -183,7 +183,7 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op)
> >> }
> >> irq = irq_of_parse_and_map(dn, 0);
> >>- if (irq == NO_IRQ) {
> >>+ if (!irq) {
> >> printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__);
> >> rv = -EBUSY;
> >> goto err_irq;
> >
> >Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
> Thanks Alan.
>
> I have seen that Grant sent the same patch to lkml too.
> Here is the thread: http://lkml.org/lkml/2012/1/11/342
>
> Grant: How fast do you think you are able to merge your patches?
Ignore my patch. It won't go in until 3.4
g.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-13 18:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-12 8:26 [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver Michal Simek
2012-01-12 15:56 ` Alan Stern
2012-01-13 11:27 ` Michal Simek
2012-01-13 18:39 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox