From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754640Ab2ANDSX (ORCPT ); Fri, 13 Jan 2012 22:18:23 -0500 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:40636 "EHLO e28smtp08.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493Ab2ANDSV (ORCPT ); Fri, 13 Jan 2012 22:18:21 -0500 Message-ID: <4F10F3EF.8000908@linux.vnet.ibm.com> Date: Sat, 14 Jan 2012 08:48:07 +0530 From: "Srivatsa S. Bhat" User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Linus Torvalds CC: Ming Lei , Djalal Harouni , Borislav Petkov , Tony Luck , Hidetoshi Seto , Ingo Molnar , Andi Kleen , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kay Sievers , gouders@et.bocholt.fh-gelsenkirchen.de, Marcos Souza , Linux PM mailing list , "Rafael J. Wysocki" , "tglx@linutronix.de" , prasad@linux.vnet.ibm.com, justinmattock@gmail.com, Jeff Chua , Suresh B Siddha , Peter Zijlstra , Mel Gorman , Gilad Ben-Yossef Subject: Re: x86/mce: machine check warning during poweroff References: <20120111000051.GA28874@dztty> <4F10929E.8070007@linux.vnet.ibm.com> <4F10BDF7.8030306@linux.vnet.ibm.com> <4F10EB5B.5060804@linux.vnet.ibm.com> <4F10F117.40006@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit x-cbid: 12011403-2000-0000-0000-0000060A0B96 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/14/2012 08:40 AM, Linus Torvalds wrote: > On Fri, Jan 13, 2012 at 7:05 PM, Srivatsa S. Bhat > wrote: >>> On Fri, Jan 13, 2012 at 6:41 PM, Srivatsa S. Bhat >>> wrote: >>> >>>> The patch below works perfectly for me - I tested multiple CPU hotplug >>>> operations as well as multiple pm_test runs at core level. Please let me >>>> know if this solves the suspend issue as well.. >>> >>> Ok, I'll try, and I bet it does. > > Yup, I can suspend and resume multiple times now. Wow! Feels good to hear that, at last! :-) By the way, in my excitement, while sending the patch I forgot to give credits to the problem reporters with a "Reported-by". Hope that gets resolved. > >> I totally agree with you. Even I had set out to find out *exactly* what >> was going wrong. After spending significant amount of time digging through >> the code (unsuccessfully), this idea of zeroing out everything struck me >> and it worked, as expected. Yes, it is definitely important to know the >> exact issue so that we can fix the driver core and avoid other mishaps, >> but I guess finding that out is not all that simple.. as of now I am >> rather exhausted following those zillions of pointers continuously >> for the past few hours.. ;-/ > > Fair enough. The many layers of clever indirection are really really > nasty to follow, I agree. > :-) Regards, Srivatsa S. Bhat IBM Linux Technology Center