From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752850Ab2APAb5 (ORCPT ); Sun, 15 Jan 2012 19:31:57 -0500 Received: from mail9.hitachi.co.jp ([133.145.228.44]:47624 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859Ab2APAb4 (ORCPT ); Sun, 15 Jan 2012 19:31:56 -0500 X-AuditID: b753bd60-9785eba00000359c-a5-4f136ffa2bc2 X-AuditID: b753bd60-9785eba00000359c-a5-4f136ffa2bc2 Message-ID: <4F136FED.8090201@hitachi.com> Date: Mon, 16 Jan 2012 09:31:41 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Ulrich Drepper Cc: Linux Kernel Mailing List , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, yrl.pp-manager.tt@hitachi.com Subject: Re: Typo transferred from Intel manual References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ulrich, (2012/01/14 7:24), Ulrich Drepper wrote: > The arch/x86/lib/x86-opcode-map.txt file contains the line > > af: SCAS/W/D/Q rAX,Xv > > > This is what the Intel manuals show, but it's not correct. The 'X' stands for > > Memory addressed by the DS:rSI register pair (for example, MOVS, CMPS, > OUTS, or LODS). > > > On the other hand 'Y' means (also see the ae byte entry for SCASB): > > Memory addressed by the ES:rDI register pair (for example, MOVS, CMPS, > INS, STOS, or SCAS). I see, thanks for reporting :) > Hence the following patch should be applied: Could you add a comment line above the fix in x86-opcode-map.txt? I just consider the case that someone may confuse the fix itself is typo. Thank you! > > > Signed-off-by: Ulrich Drepper > > diff --git a/arch/x86/lib/x86-opcode-map.txt b/arch/x86/lib/x86-opcode-map.txt > index 5b83c51..c292885 100644 > --- a/arch/x86/lib/x86-opcode-map.txt > +++ b/arch/x86/lib/x86-opcode-map.txt > @@ -219,7 +219,7 @@ ab: STOS/W/D/Q Yv,rAX > ac: LODS/B AL,Xb > ad: LODS/W/D/Q rAX,Xv > ae: SCAS/B AL,Yb > -af: SCAS/W/D/Q rAX,Xv > +af: SCAS/W/D/Q rAX,Yv > # 0xb0 - 0xbf > b0: MOV AL/R8L,Ib > b1: MOV CL/R9L,Ib > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com