From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753407Ab2APH2F (ORCPT ); Mon, 16 Jan 2012 02:28:05 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:50646 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751284Ab2APH2D (ORCPT ); Mon, 16 Jan 2012 02:28:03 -0500 Message-ID: <4F13D216.3060705@cn.fujitsu.com> Date: Mon, 16 Jan 2012 15:30:30 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc14 Thunderbird/3.1.4 MIME-Version: 1.0 To: Cong Wang CC: Michal Marek , Arnaud Lacombe , Davidlohr Bueso , LKML , linux-kbuild@vger.kernel.org Subject: Re: [PATCH] kconfig: fix a regression when exiting menuconfig without saving References: <4F13CB49.8030004@cn.fujitsu.com> <1326698421.4151.4.camel@cr0> In-Reply-To: <1326698421.4151.4.camel@cr0> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2012-01-16 15:26:52, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2012-01-16 15:26:54, Serialize complete at 2012-01-16 15:26:54 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cong Wang wrote: > On Mon, 2012-01-16 at 15:01 +0800, Li Zefan wrote: >> $ make menuconfig >> HOSTCC scripts/kconfig/mconf.o >> HOSTLD scripts/kconfig/mconf >> scripts/kconfig/mconf Kconfig >> >> Your configuration changes were NOT saved. >> >> make[1]: *** [menuconfig] Error 1 >> make: *** [menuconfig] Error 2 >> >> Exiting menuconfig without saving, make will report error. > > This should be fixed by "[PATCH] scripts:kconfig:mconf.c: let make not > report error when not save configuration". > I didn't notice that patch. I just took a look on it, and unfortunately that patch is wrong, in that now pressing ESC in the Yes/No dialog will exit menuconfig instead of returning to the main menu.