public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Cong Wang <amwang@redhat.com>,
	Arnaud Lacombe <lacombar@gmail.com>,
	Davidlohr Bueso <dave@gnu.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-kbuild@vger.kernel.org, Wang YanQing <udknight@gmail.com>
Subject: Re: [PATCH] menuconfig: fix a regression when canceling the prompt dialog at exit
Date: Mon, 16 Jan 2012 14:44:22 +0100	[thread overview]
Message-ID: <4F1429B6.9080104@suse.cz> (raw)
In-Reply-To: <4F13D873.4070808@cn.fujitsu.com>

On 16.1.2012 08:57, Li Zefan wrote:
> This commit fixes a bug, while introducing a new one..
> 
> commit 7203ddbd4be9720649e47d756a001e0c7d7f8ae2
> Author: Wang YanQing <udknight@gmail.com>
> Date:   Thu Jan 12 11:31:32 2012 +0800
> 
>     menuconfig: let make not report error when not save configuration
> 
> Pressing ESC should cancel the yes/no dialog and return back to
> the main menu, but not exit from menuconfig.

Thanks, applied. Note that in the Ctrl-C case, ESC still exits with an
error. Changing sig_handler() to only exit if res != KEY_ESC is not
sufficient, as the dialog is not redrawn. Hm.

Michal

      parent reply	other threads:[~2012-01-16 13:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-16  7:01 [PATCH] kconfig: fix a regression when exiting menuconfig without saving Li Zefan
2012-01-16  7:20 ` Cong Wang
2012-01-16  7:30   ` Li Zefan
2012-01-16  7:57     ` [PATCH] menuconfig: fix a regression when canceling the prompt dialog at exit Li Zefan
2012-01-16  8:05       ` Wang YanQing
2012-01-16 13:44       ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1429B6.9080104@suse.cz \
    --to=mmarek@suse.cz \
    --cc=amwang@redhat.com \
    --cc=dave@gnu.org \
    --cc=lacombar@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=udknight@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox