From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756875Ab2ASRE7 (ORCPT ); Thu, 19 Jan 2012 12:04:59 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:6660 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770Ab2ASRE6 (ORCPT ); Thu, 19 Jan 2012 12:04:58 -0500 Message-ID: <4F184D28.3030207@parallels.com> Date: Thu, 19 Jan 2012 21:04:40 +0400 From: Stanislav Kinsbursky User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111109 Lightning/1.0b2 Thunderbird/3.1.16 MIME-Version: 1.0 To: "J. Bruce Fields" CC: "Trond.Myklebust@netapp.com" , "linux-nfs@vger.kernel.org" , Pavel Emelianov , "neilb@suse.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Bottomley , "davem@davemloft.net" , "devel@openvz.org" Subject: Re: [PATCH 3/5] SUNRPC: create GSS auth cache per network namespace References: <20120119144517.9957.59143.stgit@localhost6.localdomain6> <20120119144922.9957.39352.stgit@localhost6.localdomain6> <20120119163149.GD527@fieldses.org> In-Reply-To: <20120119163149.GD527@fieldses.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 19.01.2012 20:31, J. Bruce Fields пишет: > On Thu, Jan 19, 2012 at 06:49:23PM +0400, Stanislav Kinsbursky wrote: >> @@ -1000,6 +996,7 @@ static int svcauth_gss_handle_init(struct svc_rqst *rqstp, >> struct xdr_netobj tmpobj; >> struct rsi *rsip, rsikey; >> int ret; >> + struct sunrpc_net *sn = net_generic(rqstp->rq_xprt->xpt_net, sunrpc_net_id); > > OK, so you're getting the network namespace out of the rqstp, and, then > passing it down, makes sense. And: > >> @@ -1079,6 +1076,7 @@ svcauth_gss_accept(struct svc_rqst *rqstp, __be32 *authp) >> __be32 *rpcstart; >> __be32 *reject_stat = resv->iov_base + resv->iov_len; >> int ret; >> + struct sunrpc_net *sn = net_generic(rqstp->rq_xprt->xpt_net, sunrpc_net_id); > > ... same for the gss cache. Looks good. > > How do you plan to test this? > Do you mean something special or in general? Currently I validate all my chages in container by using simple test environment. I would be appreciate for any hints to tests, than can help. -- Best regards, Stanislav Kinsbursky