public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [v3.3-rc1] media:dvb-t regression bisected
@ 2012-01-22 15:29 Jörg Otte
  2012-01-23 11:14 ` Mauro Carvalho Chehab
  2012-01-23 11:45 ` Mauro Carvalho Chehab
  0 siblings, 2 replies; 4+ messages in thread
From: Jörg Otte @ 2012-01-22 15:29 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mauro Carvalho Chehab

with v3.3-rc1 I can not watch dvb-t. I get the following
errors from the media player (Kaffeine,vlc):

kaffeine(1801): DvbDevice::frontendEvent: tuning failed
vlc: [0xa278d78] main stream error: cannot pre fill buffer

I have a CinergyT2 usb-stick.

I was able to bisect the problem to:
commit 7830bbaff9f5f9cefcdc9acfb1783b230cc69fac
Author: Mauro Carvalho Chehab <mchehab@redhat.com>
Date:   Mon Dec 26 15:41:01 2011 -0300

[media] cinergyT2-fe: convert set_fontend to use DVBv5 parameters

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [v3.3-rc1] media:dvb-t regression bisected
  2012-01-22 15:29 [v3.3-rc1] media:dvb-t regression bisected Jörg Otte
@ 2012-01-23 11:14 ` Mauro Carvalho Chehab
  2012-01-23 11:45 ` Mauro Carvalho Chehab
  1 sibling, 0 replies; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2012-01-23 11:14 UTC (permalink / raw)
  To: Jörg Otte; +Cc: linux-kernel

Em 22-01-2012 13:29, Jörg Otte escreveu:
> with v3.3-rc1 I can not watch dvb-t. I get the following
> errors from the media player (Kaffeine,vlc):
> 
> kaffeine(1801): DvbDevice::frontendEvent: tuning failed
> vlc: [0xa278d78] main stream error: cannot pre fill buffer
> 
> I have a CinergyT2 usb-stick.
> 
> I was able to bisect the problem to:
> commit 7830bbaff9f5f9cefcdc9acfb1783b230cc69fac
> Author: Mauro Carvalho Chehab <mchehab@redhat.com>
> Date:   Mon Dec 26 15:41:01 2011 -0300
> 
> [media] cinergyT2-fe: convert set_fontend to use DVBv5 parameters

Could you please try this patch?

[PATCH] cinergyT2-fe: Fix bandwdith settings

Changeset 7830bbaff9f mangled the bandwidth field for CinergyT2.
Properly fill it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/dvb/dvb-usb/cinergyT2-fe.c b/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
index 8a57ed8..1efc028 100644
--- a/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
+++ b/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
@@ -276,14 +276,15 @@ static int cinergyt2_fe_set_frontend(struct dvb_frontend *fe)
 	param.flags = 0;
 
 	switch (fep->bandwidth_hz) {
+	default:
 	case 8000000:
-		param.bandwidth = 0;
+		param.bandwidth = 8;
 		break;
 	case 7000000:
-		param.bandwidth = 1;
+		param.bandwidth = 7;
 		break;
 	case 6000000:
-		param.bandwidth = 2;
+		param.bandwidth = 6;
 		break;
 	}
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [v3.3-rc1] media:dvb-t regression bisected
  2012-01-22 15:29 [v3.3-rc1] media:dvb-t regression bisected Jörg Otte
  2012-01-23 11:14 ` Mauro Carvalho Chehab
@ 2012-01-23 11:45 ` Mauro Carvalho Chehab
  2012-01-23 15:09   ` Jörg Otte
  1 sibling, 1 reply; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2012-01-23 11:45 UTC (permalink / raw)
  To: Jörg Otte; +Cc: linux-kernel, Linux Media Mailing List

Em 22-01-2012 13:29, Jörg Otte escreveu:
> with v3.3-rc1 I can not watch dvb-t. I get the following
> errors from the media player (Kaffeine,vlc):
> 
> kaffeine(1801): DvbDevice::frontendEvent: tuning failed
> vlc: [0xa278d78] main stream error: cannot pre fill buffer
> 
> I have a CinergyT2 usb-stick.
> 
> I was able to bisect the problem to:
> commit 7830bbaff9f5f9cefcdc9acfb1783b230cc69fac
> Author: Mauro Carvalho Chehab <mchehab@redhat.com>
> Date:   Mon Dec 26 15:41:01 2011 -0300
> 
> [media] cinergyT2-fe: convert set_fontend to use DVBv5 parameters

Could you please try this patch?

[PATCH] cinergyT2-fe: Fix bandwdith settings

Changeset 7830bbaff9f mangled the bandwidth field for CinergyT2.
Properly fill it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/dvb/dvb-usb/cinergyT2-fe.c b/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
index 8a57ed8..1efc028 100644
--- a/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
+++ b/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
@@ -276,14 +276,15 @@ static int cinergyt2_fe_set_frontend(struct dvb_frontend *fe)
 	param.flags = 0;
 
 	switch (fep->bandwidth_hz) {
+	default:
 	case 8000000:
-		param.bandwidth = 0;
+		param.bandwidth = 8;
 		break;
 	case 7000000:
-		param.bandwidth = 1;
+		param.bandwidth = 7;
 		break;
 	case 6000000:
-		param.bandwidth = 2;
+		param.bandwidth = 6;
 		break;
 	}
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [v3.3-rc1] media:dvb-t regression bisected
  2012-01-23 11:45 ` Mauro Carvalho Chehab
@ 2012-01-23 15:09   ` Jörg Otte
  0 siblings, 0 replies; 4+ messages in thread
From: Jörg Otte @ 2012-01-23 15:09 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-kernel

Thank you very much, the patch works!

Joerg


2012/1/23 Mauro Carvalho Chehab <mchehab@redhat.com>:
> Em 22-01-2012 13:29, Jörg Otte escreveu:
>> with v3.3-rc1 I can not watch dvb-t. I get the following
>> errors from the media player (Kaffeine,vlc):
>>
>> kaffeine(1801): DvbDevice::frontendEvent: tuning failed
>> vlc: [0xa278d78] main stream error: cannot pre fill buffer
>>
>> I have a CinergyT2 usb-stick.
>>
>> I was able to bisect the problem to:
>> commit 7830bbaff9f5f9cefcdc9acfb1783b230cc69fac
>> Author: Mauro Carvalho Chehab <mchehab@redhat.com>
>> Date:   Mon Dec 26 15:41:01 2011 -0300
>>
>> [media] cinergyT2-fe: convert set_fontend to use DVBv5 parameters
>
> Could you please try this patch?
>
> [PATCH] cinergyT2-fe: Fix bandwdith settings
>
> Changeset 7830bbaff9f mangled the bandwidth field for CinergyT2.
> Properly fill it.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> diff --git a/drivers/media/dvb/dvb-usb/cinergyT2-fe.c b/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
> index 8a57ed8..1efc028 100644
> --- a/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
> +++ b/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
> @@ -276,14 +276,15 @@ static int cinergyt2_fe_set_frontend(struct dvb_frontend *fe)
>        param.flags = 0;
>
>        switch (fep->bandwidth_hz) {
> +       default:
>        case 8000000:
> -               param.bandwidth = 0;
> +               param.bandwidth = 8;
>                break;
>        case 7000000:
> -               param.bandwidth = 1;
> +               param.bandwidth = 7;
>                break;
>        case 6000000:
> -               param.bandwidth = 2;
> +               param.bandwidth = 6;
>                break;
>        }
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-01-23 15:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-22 15:29 [v3.3-rc1] media:dvb-t regression bisected Jörg Otte
2012-01-23 11:14 ` Mauro Carvalho Chehab
2012-01-23 11:45 ` Mauro Carvalho Chehab
2012-01-23 15:09   ` Jörg Otte

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox