linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] acer-wmi: support for P key on TM8372
@ 2012-01-23 20:35 Ike Panhc
  2012-01-26  2:28 ` joeyli
  0 siblings, 1 reply; 4+ messages in thread
From: Ike Panhc @ 2012-01-23 20:35 UTC (permalink / raw)
  To: platform-driver-x86, linux-kernel
  Cc: Merlin Schumacher, Joey Lee, Matthew Garrett

From: Merlin Schumacher <merlin.schumacher@gmail.com>

BugLink: http://launchpad.net/bugs/865807

There is no entry for P key on TM8372, so when P key is pressed, only
"acer_wmi: Unknown key number - 0x29" in dmesg.

Signed-off-by: Merlin Schumacher <merlin.schumacher@gmail.com>
Signed-off-by: Ike Panhc <ike.pan@canonical.com>
---
 drivers/platform/x86/acer-wmi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index b848277..d48262c 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -105,6 +105,7 @@ static const struct key_entry acer_wmi_keymap[] = {
 	{KE_KEY, 0x22, {KEY_PROG2} },    /* Arcade */
 	{KE_KEY, 0x23, {KEY_PROG3} },    /* P_Key */
 	{KE_KEY, 0x24, {KEY_PROG4} },    /* Social networking_Key */
+	{KE_KEY, 0x29, {KEY_PROG3} },    /* P_Key for TM8372 */
 	{KE_IGNORE, 0x41, {KEY_MUTE} },
 	{KE_IGNORE, 0x42, {KEY_PREVIOUSSONG} },
 	{KE_IGNORE, 0x43, {KEY_NEXTSONG} },
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] acer-wmi: support for P key on TM8372
@ 2012-02-06 10:08 Joey Lee
  0 siblings, 0 replies; 4+ messages in thread
From: Joey Lee @ 2012-02-06 10:08 UTC (permalink / raw)
  To: merlin.schumacher
  Cc: ike.pan, mjg, Joey Lee, linux-kernel, platform-driver-x86

Hi Merlin, 

於 四，2012-01-26 於 12:53 +0100，Merlin Schumacher 提到：
> Am 26.01.2012 03:28, schrieb joeyli:
> > Hi Ike,
> >
> > 於 二，2012-01-24 於 04:35 +0800，Ike Panhc 提到：
> >> From: Merlin Schumacher<merlin.schumacher@gmail.com>
> >>
> >> BugLink: http://launchpad.net/bugs/865807
> >>
> >> There is no entry for P key on TM8372, so when P key is pressed, only
> >> "acer_wmi: Unknown key number - 0x29" in dmesg.
> >>
> >> Signed-off-by: Merlin Schumacher<merlin.schumacher@gmail.com>
> >> Signed-off-by: Ike Panhc<ike.pan@canonical.com>
> >
> > Reviewed-by: Lee, Chun-Yi<jlee@suse.com>
> >
> >> ---
> >>   drivers/platform/x86/acer-wmi.c |    1 +
> >>   1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> >> index b848277..d48262c 100644
> >> --- a/drivers/platform/x86/acer-wmi.c
> >> +++ b/drivers/platform/x86/acer-wmi.c
> >> @@ -105,6 +105,7 @@ static const struct key_entry acer_wmi_keymap[] = {
> >>   	{KE_KEY, 0x22, {KEY_PROG2} },    /* Arcade */
> >>   	{KE_KEY, 0x23, {KEY_PROG3} },    /* P_Key */
> >>   	{KE_KEY, 0x24, {KEY_PROG4} },    /* Social networking_Key */
> >> +	{KE_KEY, 0x29, {KEY_PROG3} },    /* P_Key for TM8372 */
> >>   	{KE_IGNORE, 0x41, {KEY_MUTE} },
> >>   	{KE_IGNORE, 0x42, {KEY_PREVIOUSSONG} },
> >>   	{KE_IGNORE, 0x43, {KEY_NEXTSONG} },
> >
> > This patch has no problem, but could you please provide the dmidecode
> > result to me for reference?
> >
> >
> > Thanks a lot!
> > Joey Lee
> >
> 
> Hi,
> 
> attached you'll find the output of dmidecode on the TM8372. If you need 
> anything else, let me know.
> 
> You're welcome
> 
> Merlin Schumacher
> 
> 

Thanks for your dmidecode log of TM8372, I can keep it for regression
test after add new functions.


Thanks a lot!
Joey Lee



^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-06 10:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-23 20:35 [PATCH] acer-wmi: support for P key on TM8372 Ike Panhc
2012-01-26  2:28 ` joeyli
2012-01-26 11:53   ` Merlin Schumacher
  -- strict thread matches above, loose matches on Subject: below --
2012-02-06 10:08 Joey Lee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).