From: Ryan Mallon <rmallon@gmail.com>
To: airlied@linux.ie, airlied@redhat.com, thellstrom@vmware.com,
jakob@vmware.com
Cc: dri-devel@lists.freedesktop.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
joe Perches <joe@perches.com>
Subject: [RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle
Date: Fri, 27 Jan 2012 17:25:12 +1100 [thread overview]
Message-ID: <4F224348.8050607@gmail.com> (raw)
The assignment of handle in vmw_framebuffer_create_handle doesn't
actually do anything useful and is incorrectly assigning an integer
value to a pointer argument. It appears that this is a typo and should
be dereferencing handle rather than assigning to it directly.
Signed-off-by: Ryan Mallon <rmallon@gmail.com>
---
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 0af6ebd..b66ef0e 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -378,7 +378,7 @@ int vmw_framebuffer_create_handle(struct drm_framebuffer *fb,
unsigned int *handle)
{
if (handle)
- handle = 0;
+ *handle = 0;
return 0;
}
next reply other threads:[~2012-01-27 6:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 6:25 Ryan Mallon [this message]
2012-01-27 14:09 ` [RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle Thomas Hellstrom
2012-01-27 14:24 ` Jakob Bornecrantz
2012-01-27 14:28 ` Thomas Hellstrom
2012-01-27 14:41 ` Jakob Bornecrantz
2012-01-27 14:54 ` Thomas Hellstrom
2012-01-27 15:01 ` Jakob Bornecrantz
2012-01-27 15:32 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F224348.8050607@gmail.com \
--to=rmallon@gmail.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jakob@vmware.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox