From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755974Ab2A0PV3 (ORCPT ); Fri, 27 Jan 2012 10:21:29 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:22886 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408Ab2A0PV2 (ORCPT ); Fri, 27 Jan 2012 10:21:28 -0500 Message-ID: <4F22C0EE.4090701@parallels.com> Date: Fri, 27 Jan 2012 19:21:18 +0400 From: Stanislav Kinsbursky User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111109 Lightning/1.0b2 Thunderbird/3.1.16 MIME-Version: 1.0 To: "J. Bruce Fields" CC: "Trond.Myklebust@netapp.com" , "linux-nfs@vger.kernel.org" , Pavel Emelianov , "neilb@suse.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Bottomley , "davem@davemloft.net" , "devel@openvz.org" Subject: Re: [PATCH 3/4] SUNRPC: service destruction in network namespace context References: <20120125134132.13662.83447.stgit@localhost6.localdomain6> <20120125134726.13662.97179.stgit@localhost6.localdomain6> <20120126211450.GD700@fieldses.org> <4F226976.5000605@parallels.com> <20120127143335.GB9439@fieldses.org> In-Reply-To: <20120127143335.GB9439@fieldses.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 27.01.2012 18:33, J. Bruce Fields пишет: > OK, so at this point svc_close_net(serv, current->nsproxy->net_ns) is > enough to clear out sv_permsocks and sv_temp_socks because we know that > the only sockets left are in that namespace. Got it. > BTW, is this approach looks suitable for NFSd service? > I'm not sure. The one thing that might have helped mere here would be > a comment to explain what's going on, maybe something like: > > svc_close_net(serv, net); > + /* > + * The last user is gone, so the only sockets left belonged its > + * network namespace: > + */ > BUG_ON(!list_empty(&serv->sv_permsocks)); > BUG_ON(!list_empty(&serv->sv_tempsocks)); Ok, can do so. -- Best regards, Stanislav Kinsbursky