From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756097Ab2A0PcZ (ORCPT ); Fri, 27 Jan 2012 10:32:25 -0500 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:37043 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754239Ab2A0PcY (ORCPT ); Fri, 27 Jan 2012 10:32:24 -0500 Message-ID: <4F22C385.5020104@vmware.com> Date: Fri, 27 Jan 2012 16:32:21 +0100 From: Thomas Hellstrom User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Ryan Mallon CC: airlied@linux.ie, airlied@redhat.com, jakob@vmware.com, dri-devel@lists.freedesktop.org, "linux-kernel@vger.kernel.org" , joe Perches Subject: Re: [RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle References: <4F224348.8050607@gmail.com> In-Reply-To: <4F224348.8050607@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/27/2012 07:25 AM, Ryan Mallon wrote: > The assignment of handle in vmw_framebuffer_create_handle doesn't > actually do anything useful and is incorrectly assigning an integer > value to a pointer argument. It appears that this is a typo and should > be dereferencing handle rather than assigning to it directly. > > Signed-off-by: Ryan Mallon > --- > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > index 0af6ebd..b66ef0e 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > @@ -378,7 +378,7 @@ int vmw_framebuffer_create_handle(struct drm_framebuffer *fb, > unsigned int *handle) > { > if (handle) > - handle = 0; > + *handle = 0; > > return 0; > } > Ryan, Please repost this patch with Jakobs Reviewed-by: and below that a Cc: stable@vger.kernel.org Thanks, Thomas