From: Larry Finger <Larry.Finger@lwfinger.net>
To: "devendra.aaru" <devendra.aaru@gmail.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: so many if conditions in _rtl92c_store_pwrIndex_diffrate_offset.
Date: Sat, 28 Jan 2012 10:44:17 -0600 [thread overview]
Message-ID: <4F2425E1.7090407@lwfinger.net> (raw)
In-Reply-To: <CAHdPZaMWC6_bGXXJvjbmJDz-JDF7gx8QUTd2e8iW=5+ecTPiSg@mail.gmail.com>
On 01/28/2012 12:31 AM, devendra.aaru wrote:
> Hi wireless folks,
>
> in _rtl92c_store_pwrIndex_diffrate_offset (
> drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c), there are lot of
> if conditions, checking the register address.
> my understanding is that if the register address matches to a
> particular rate, we set the txpower level to a particular group. but
> it is even possible with the switch or if else if statements,
> please correct me if i am wrong.
Of course, that routine could be recoded using either a switch or if else
statements. Unfortunately, I have more pressing matters to attend to. You can,
however, submit a patch to change it and send it to the linux-wireless mailing
list. You must follow the instructions in Documentation/SubmittingPatches, and
the patch must apply using the wireless-testing git tree.
Larry
prev parent reply other threads:[~2012-01-28 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 6:31 so many if conditions in _rtl92c_store_pwrIndex_diffrate_offset devendra.aaru
2012-01-28 16:44 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2425E1.7090407@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=devendra.aaru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox